Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add support for clippy-driver to sccache #728

Merged
merged 1 commit into from
May 6, 2020
Merged

add support for clippy-driver to sccache #728

merged 1 commit into from
May 6, 2020

Conversation

yaahc
Copy link
Contributor

@yaahc yaahc commented Apr 23, 2020

@yaahc
Copy link
Contributor Author

yaahc commented Apr 23, 2020

This is admittedly not a great solution, with this approach every single binary that wants to work as a RUSTC_WORKSPACE_WRAPPER and sccache will need to be added to this list. Long term I expect this should be changed to detect rustc without ever checking the name of the binary, I wouldn't mind doing that as part of this PR but I didn't want to spend the time exploring sccache enough to be confident in my changes beyond this minimal fix.

@froydnj froydnj merged commit f502075 into mozilla:master May 6, 2020
@froydnj
Copy link
Contributor

froydnj commented May 6, 2020

Thank you!

@phansch phansch mentioned this pull request May 16, 2020
Closed
@ehuss ehuss mentioned this pull request Mar 2, 2021
Open
@badboy badboy mentioned this pull request Mar 26, 2021
Merged
@amousset amousset mentioned this pull request Aug 3, 2022
Closed
@Shnatsel Shnatsel mentioned this pull request Aug 10, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

--fix fails sometimes if clippy and sccache used: "error: Unrecognized option: \'E\'\n\n
2 participants
@yaahc @froydnj