Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix clippy suggestions (in beta) #1568

Merged
merged 3 commits into from
Mar 26, 2021
Merged

Fix clippy suggestions (in beta) #1568

merged 3 commits into from
Mar 26, 2021

Conversation

badboy
Copy link
Member

@badboy badboy commented Mar 26, 2021

This is valid code in release, so we can apply them now.

@auto-assign auto-assign bot requested a review from brizental March 26, 2021 15:01
@badboy badboy requested review from mdboom and removed request for brizental March 26, 2021 15:02
@badboy
Copy link
Member Author

badboy commented Mar 26, 2021 

[task 2021-03-26T15:06:03.536Z] error: failed to execute compile
[task 2021-03-26T15:06:03.536Z] caused by: Compiler not supported: "error: Unrecognized option: \'E\'\n\n"
[task 2021-03-26T15:06:03.536Z] error: failed to execute compile
[task 2021-03-26T15:06:03.536Z] caused by: Compiler not supported: "error: Unrecognized option: \'E\'\n\n"
[task 2021-03-26T15:06:03.537Z] error: could not compile `glean-core`

I have no idea where that error is coming from.

@badboy
Copy link
Member Author

badboy commented Mar 26, 2021

sccache error. I'm going to remove our use of it, we don't store its cache so there's no benefit for us right now.

@badboy
TC: Remove sccache as a wrapper
cab947e 
The version we use doesn't play well with clippy.
We don't restore its cache anyway, so no need to use it.

(Not dropping it from the Dockerfile to avoid a lengthy rebuild of the
image)
@badboy badboy enabled auto-merge March 26, 2021 15:27
@badboy badboy merged commit ec0a9b4 into main Mar 26, 2021
@badboy badboy deleted the beta-clippy-fixes branch March 26, 2021 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mdboom mdboom mdboom approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@badboy @mdboom