fix: add missing eventsource-parser dependency #424
Merged
+2
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@domnit are you still working on this? Could you resolve the conflicts? |
| @@ -50,6 +50,7 @@ | |||
| "cors": "^2.8.5", | |||
| "cross-spawn": "^7.0.3", | |||
| "eventsource": "^3.0.2", | |||
| "eventsource-parser": "^3.0.0", | |||
There was a problem hiding this comment.
Looks like eventsource lists ^3.0.1, might be good to follow it
https://github.com/EventSource/eventsource/blob/d4385cb8d4c8f59949c4dd64412b199c9b57d8db/package.json#L66
There was a problem hiding this comment.
eventsource used here is 3.0.2, which had 3.0.0 eventsource-parser dependency
ihrpr
approved these changes
Jun 27, 2025
| @@ -50,6 +50,7 @@ | |||
| "cors": "^2.8.5", | |||
| "cross-spawn": "^7.0.3", | |||
| "eventsource": "^3.0.2", | |||
| "eventsource-parser": "^3.0.0", | |||
There was a problem hiding this comment.
eventsource used here is 3.0.2, which had 3.0.0 eventsource-parser dependency
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds missing dependency on
eventsource-parser.Motivation and Context
src/client/streamableHttp.tsimports fromeventsource-parserbut the package was not listed inpackage.json.How Has This Been Tested?
Fixed the build in a test client application.
Breaking Changes
None
Types of changes
Checklist
Additional context