Skip to content

eventsource-parser should be an explicit npm dependency #499

Open
@arthuraraujo-msft

Description

@arthuraraujo-msft

eventsource-parser is currently included in the project transitively through the dependency eventsource, which is actually listed in package.json.

It is however used directly in the sdk code:

import { EventSourceParserStream } from "eventsource-parser/stream";

We should include all dependencies explicitly to ensure the code keeps working without depending on other packages having them listed as their own dependencies. Also, in flows where sub-dependencies are not installed in the same location as the explicit dependencies, this could lead to a failure.

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Type

    No type

    Projects

    Status

    To triage

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions