Add capability to correctly export fixed buckets histogram to SignalFx #2977
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bogdandrutu
force-pushed
the
testgauge
branch
from
932d860 to
8679f50
Compare
![sonatype-lift[bot]](https://avatars.githubusercontent.com/in/9843?s=60&v=4){kind=small}
...ations/micrometer-registry-signalfx/src/main/java/io/micrometer/signalfx/SignalFxConfig.java
Outdated
Show resolved
Hide resolved
mateuszrzeszutek
approved these changes
Jan 17, 2022
...micrometer-registry-signalfx/src/main/java/io/micrometer/signalfx/SignalFxMeterRegistry.java
Outdated
Show resolved
Hide resolved
bogdandrutu
force-pushed
the
testgauge
branch
from
51dccec to
20c2d54
Compare
|
@jonatan-ivanov can you please review/merge this :)? |
jonatan-ivanov
requested changes
Jan 21, 2022
...micrometer-registry-signalfx/src/main/java/io/micrometer/signalfx/SignalFxMeterRegistry.java
Outdated
Show resolved
Hide resolved
...micrometer-registry-signalfx/src/main/java/io/micrometer/signalfx/SignalFxMeterRegistry.java
Outdated
Show resolved
Hide resolved
...ations/micrometer-registry-signalfx/src/main/java/io/micrometer/signalfx/SignalFxConfig.java
Outdated
Show resolved
Hide resolved
...micrometer-registry-signalfx/src/main/java/io/micrometer/signalfx/SignalFxMeterRegistry.java
Outdated
Show resolved
Hide resolved
...micrometer-registry-signalfx/src/main/java/io/micrometer/signalfx/SignalFxMeterRegistry.java
Outdated
Show resolved
Hide resolved
bogdandrutu
force-pushed
the
testgauge
branch
from
fcba9d3 to
e2b8677
Compare
|
@jonatan-ivanov (and Micrometer maintainers) PTAL at this PR -- I've fixed the issues with |
jonatan-ivanov
approved these changes
Mar 18, 2022
* Fix to always include the "+Inf" bucket. * Fix to never expire per bucket counters. * The metrics are still reported as Gauges by default, to fix this user has to enable a property. Signed-off-by: Bogdan Drutu <[email protected]>
Signed-off-by: Bogdan Drutu <[email protected]>
jonatan-ivanov
force-pushed
the
testgauge
branch
from
74972e8 to
79693ed
Compare
|
@bogdandrutu @mateuszrzeszutek Thank you for the change! |
...ations/micrometer-registry-signalfx/src/main/java/io/micrometer/signalfx/SignalFxConfig.java
Show resolved
Hide resolved
jonatan-ivanov
added
enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Bogdan Drutu [email protected]