Address feedback

Signed-off-by: Bogdan Drutu <[email protected]>

Author: bogdandrutu

implementations/micrometer-registry-signalfx/src/main/java/io/micrometer/signalfx/SignalFxConfig.java

@@ -43,12 +43,14 @@ default String accessToken() {
     }
 
     /**
-     * Returns {@code true} if the signalfx registry should emit histogram buckets.
+     * Returns {@code true} if the signalfx registry should emit histogram buckets as
+     * CumulativeCounter instead of Gauge (as it is by default).
      *
-     * @return {@code true} if the signalfx registry should emit histogram buckets.
+     * @return {@code true} if the signalfx registry should emit histogram buckets as
+     * CumulativeCounter instead of Gauge (as it is by default).
      */
     default Boolean fixHistogramBucketsType() {
-        return getBoolean(this, "reportHistogramBuckets").orElse(false);
+        return getBoolean(this, "fixHistogramBucketsType").orElse(false);
     }
 
     /**

implementations/micrometer-registry-signalfx/src/main/java/io/micrometer/signalfx/SignalFxMeterRegistry.java

@@ -246,14 +246,14 @@ protected TimeUnit getBaseTimeUnit() {
 
     private DistributionStatisticConfig updateConfig(
             DistributionStatisticConfig distributionStatisticConfig) {
-        // Add the +Inf bucket since the "count" resets every export.
-        double[] sla = distributionStatisticConfig.getServiceLevelObjectiveBoundaries();
-        if (sla == null || sla.length == 0) {
+        double[] sloBoundaries = distributionStatisticConfig.getServiceLevelObjectiveBoundaries();
+        if (sloBoundaries == null || sloBoundaries.length == 0) {
             return distributionStatisticConfig;
         }
-        double[] newSLA = sla;
-        if (!isPositiveInf(sla[sla.length - 1])) {
-            newSLA = Arrays.copyOf(sla, sla.length + 1);
+        double[] newSLA = sloBoundaries;
+        // Add the +Inf bucket since the "count" resets every export.
+        if (!isPositiveInf(sloBoundaries[sloBoundaries.length - 1])) {
+            newSLA = Arrays.copyOf(sloBoundaries, sloBoundaries.length + 1);
             newSLA[newSLA.length - 1] = Double.MAX_VALUE;
         }
         return DistributionStatisticConfig.builder()