Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: deletion of untouched machines #81

Merged
merged 2 commits into from
Mar 7, 2025

Conversation

vknabel
Copy link
Contributor

@vknabel vknabel commented Mar 6, 2025

Description

When trying to delete a metalstackmachine that has not yet been created, it still tried to find it. Resulting in the following error and a deadlock.

capms-controller-manager-8469bcdb77-qntkg manager 2025-03-06T10:52:11Z    ERROR   Reconciler error        {"controller": "metalstackmachine", "controllerGroup": "infrastructure.cluster.x-k8s.io", "controllerKind": "MetalStackMachine", "MetalStackMachine": {"name":"metal-test-md-0-zvdmm-d4m2m","namespace":"default"}, "namespace": "default", "name": "metal-test-md-0-zvdmm-d4m2m", "reconcileID": "0fa4ed89-6f86-4062-b2f4-f32e3defc479", "error": "failed to find provider machine: json: cannot unmarshal array into Go value of type models.V1MachineResponse"}

@vknabel vknabel requested a review from simcod March 6, 2025 10:59
Copy link
Contributor

@Gerrit91 Gerrit91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general we need to consider that our code can lead to machine leakage. So, maybe we need an orphan detection or something at some point. But this is out of scope of this PR.

@Gerrit91 Gerrit91 merged commit 1d2b2d0 into main Mar 7, 2025
4 checks passed
@Gerrit91 Gerrit91 deleted the fix-deletion-of-untouched-machines branch March 7, 2025 08:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants