fix: deletion of untouched machines (#81)

vknabel · web-flow · commit 1d2b2d057906 · 2025-03-07T09:49:18.000+01:00
diff --git a/internal/controller/metalstackmachine_controller.go b/internal/controller/metalstackmachine_controller.go
@@ -532,6 +532,10 @@ func (r *machineReconciler) getMachineAddresses(m *models.V1MachineResponse) clu
 }
 
 func (r *machineReconciler) findProviderMachine() (*models.V1MachineResponse, error) {
+	if r.infraMachine.Spec.ProviderID == "" {
+		return nil, errProviderMachineNotFound
+	}
+
 	resp, err := r.metalClient.Machine().FindMachine(metalmachine.NewFindMachineParams().WithContext(r.ctx).WithID(decodeProviderID(r.infraMachine.Spec.ProviderID)), nil)
 
 	var errResp *metalmachine.FindMachineDefault

Original file line number	Diff line number	Diff line change
`@@ -532,6 +532,10 @@ func (r machineReconciler) getMachineAddresses(m models.V1MachineResponse) clu`
`532`	`532`	`}`
`533`	`533`
`534`	`534`	`func (r machineReconciler) findProviderMachine() (models.V1MachineResponse, error) {`
	`535`	`+ if r.infraMachine.Spec.ProviderID == "" {`
	`536`	`+ return nil, errProviderMachineNotFound`
	`537`	`+ }`
	`538`	`+`
`535`	`539`	`resp, err := r.metalClient.Machine().FindMachine(metalmachine.NewFindMachineParams().WithContext(r.ctx).WithID(decodeProviderID(r.infraMachine.Spec.ProviderID)), nil)`
`536`	`540`
`537`	`541`	`var errResp *metalmachine.FindMachineDefault`