added cookie security #44
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
|
Can one of the admins verify this patch? To accept patch and trigger a build add comment ".ok\W+to\W+test." |
objects would not have been parsed
handle the case where the header for set-cookie is a string and not an array
|
@slnode ok to test |
eddiemonge
suggested changes
Dec 13, 2016
| constructor(cookie, options) { | ||
| super(options); | ||
|
|
||
| cookie = _.get(cookie, 'set-cookie', cookie) |
| super(options); | ||
|
|
||
| cookie = _.get(cookie, 'set-cookie', cookie) | ||
| var cookies = _.map(_.isArray(cookie) ? cookie : [cookie], function (c) { |
There was a problem hiding this comment.
Something like this would be better I think. Less dependency on lodash
this.cookie = (Array.isArray(cookie) ? cookie : [cookie])
.map(c => c.split(';')[0])
.join('; ');
|
|
||
| describe('CookieSecurity', function() { | ||
| var CookieSecurity = require('../../').CookieSecurity; | ||
| var cookie = "cookie-value"; |
| var instance2 = new CookieSecurity(headers); | ||
|
|
||
| it('is accepted with cookie string', function () { | ||
| instance1.should.have.property("cookie", cookie); |
|
|
||
| describe('defaultOption param', function() { | ||
| it('is accepted as the second param', function() { | ||
| new CookieSecurity(cookie, {}); |
There was a problem hiding this comment.
this looks like it is missing the test part.
There was a problem hiding this comment.
I just copied and modified the existing BearerSecurity test. I'm not sure what is missing since nether bearer or cookie security tests look any different.
| var defaultOptions = { foo: 2 }; | ||
| var instance = new CookieSecurity(cookie, defaultOptions); | ||
| instance.addOptions(options); | ||
| options.should.have.property("foo", 2); |
changed double to single quotes in tests
eddiemonge
reviewed
Dec 13, 2016
| var Security = require('./security'); | ||
|
|
||
| function hasCookieHeader (cookie) { | ||
| return typeof cookie === 'object' && cookie.hasOwnProperty('set-cookie') |
| constructor(cookie, options) { | ||
| super(options); | ||
|
|
||
| cookie = hasCookieHeader(cookie) ? cookie['set-cookie'] : cookie |
|
@bhoriuchi Please sign the CLA. |
|
Can one of the admins verify this patch? |
|
Signed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #38