Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please add cookie security #38

Closed
bhoriuchi opened this issue Nov 11, 2016 · 6 comments
Closed

Please add cookie security #38

bhoriuchi opened this issue Nov 11, 2016 · 6 comments
Assignees
Labels

Comments

@bhoriuchi
Copy link
Contributor

Working with the vSphere API which requires cookie security

The following works for me, but it would be a nice enhancement to have CookieSecurity added to the ones supported by the project.

export class CookieSecurity {
  constructor (cookie, options) {
    this.cookie = cookie
  }
  addHttpHeaders (headers) {
    headers.Cookie = this.cookie
  }
}
@raymondfeng
Copy link
Contributor

@bhoriuchi Would you please submit a pull request?

@bhoriuchi
Copy link
Contributor Author

PR Created #39

@rashmihunt
Copy link
Contributor

@bhoriuchi I only merged PR 37 and I noticed that PR 39 was gone. I can't really merge PR 40 since it's not showing up in PR list and also if I do directly to the link #40 I don't see anything to merge. Can you resubmit the PR again or create a new PR and resubmit? Can you please add a test case with the PR? Thanks!

@rashmihunt
Copy link
Contributor

@bhoriuchi Thank you for the PR. Can you please include a test case in the PR?

@bhoriuchi
Copy link
Contributor Author

bhoriuchi commented Nov 30, 2016

@rashmihunt test added

@dhmlau
Copy link
Member

dhmlau commented Apr 6, 2018

Fixes via #44
Closing this ticket.

@dhmlau dhmlau closed this as completed Apr 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

8 participants