Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ast matcher] add ExportDecl in dynamically matchers #118258

Conversation

HerrCai0907
Copy link
Contributor

No description provided.

Copy link

graphite-app bot commented Dec 2, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “FP Bundles” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@llvmbot llvmbot added the clang Clang issues not falling into any other category label Dec 2, 2024
@HerrCai0907 HerrCai0907 requested a review from 5chmidti December 2, 2024 06:09
@llvmbot
Copy link
Member

llvmbot commented Dec 2, 2024

@llvm/pr-subscribers-clang

Author: Congcong Cai (HerrCai0907)

Changes

Full diff: https://github.com/llvm/llvm-project/pull/118258.diff

1 Files Affected:

  • (modified) clang/lib/ASTMatchers/Dynamic/Registry.cpp (+1)
diff --git a/clang/lib/ASTMatchers/Dynamic/Registry.cpp b/clang/lib/ASTMatchers/Dynamic/Registry.cpp
index 8d36ad5c80b5d4..8edad28bc2e58f 100644
--- a/clang/lib/ASTMatchers/Dynamic/Registry.cpp
+++ b/clang/lib/ASTMatchers/Dynamic/Registry.cpp
@@ -604,6 +604,7 @@ RegistryMaps::RegistryMaps() {
   REGISTER_MATCHER(usingDecl);
   REGISTER_MATCHER(usingEnumDecl);
   REGISTER_MATCHER(usingDirectiveDecl);
+  REGISTER_MATCHER(exportDecl);
   REGISTER_MATCHER(valueDecl);
   REGISTER_MATCHER(varDecl);
   REGISTER_MATCHER(variableArrayType);

@HerrCai0907
Copy link
Contributor Author

HerrCai0907 commented Dec 3, 2024

Do I only need to add this line? @5chmidti

Copy link
Collaborator

@AaronBallman AaronBallman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM once the ordering is fixed; no need for a test or release note in this case.

@@ -604,6 +604,7 @@ RegistryMaps::RegistryMaps() {
REGISTER_MATCHER(usingDecl);
REGISTER_MATCHER(usingEnumDecl);
REGISTER_MATCHER(usingDirectiveDecl);
REGISTER_MATCHER(exportDecl);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be kept in alphabetical order.

@HerrCai0907 HerrCai0907 merged commit c7d3859 into llvm:main Dec 3, 2024
4 of 5 checks passed
@HerrCai0907 HerrCai0907 deleted the 118255-add-the-exportdecl-matcher-to-registrycpp-as-well-clang-query branch December 3, 2024 22:43
@HerrCai0907 HerrCai0907 linked an issue Dec 6, 2024 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
clang Clang issues not falling into any other category
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add the ExportDecl matcher to Registry.cpp as well (clang-query)
3 participants