Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add the ExportDecl matcher to Registry.cpp as well (clang-query) #118255

Closed
HerrCai0907 opened this issue Dec 2, 2024 · 1 comment · Fixed by #118258
Closed

add the ExportDecl matcher to Registry.cpp as well (clang-query) #118255

HerrCai0907 opened this issue Dec 2, 2024 · 1 comment · Fixed by #118258
Assignees
Labels
clang:frontend Language frontend issues, e.g. anything involving "Sema"

Comments

@HerrCai0907
Copy link
Contributor

          > > Please add the matcher to https://github.com/llvm/llvm-project/blob/main/clang/lib/ASTMatchers/Dynamic/Registry.cpp as well (clang-query).

i will do it separately to avoid this pr become bigger.

I think you only have to add it into that file for it to work, and IMO a single PR for this change would be better. But as long as it gets added, I'm fine with it

Originally posted by @5chmidti in #117901 (comment)

@HerrCai0907 HerrCai0907 self-assigned this Dec 2, 2024
@EugeneZelenko EugeneZelenko added clang:frontend Language frontend issues, e.g. anything involving "Sema" and removed new issue labels Dec 2, 2024
@llvmbot
Copy link
Member

llvmbot commented Dec 2, 2024

@llvm/issue-subscribers-clang-frontend

Author: Congcong Cai (HerrCai0907)

> > Please add the matcher to https://github.com/llvm/llvm-project/blob/main/clang/lib/ASTMatchers/Dynamic/Registry.cpp as well (clang-query). > > i will do it separately to avoid this pr become bigger.

I think you only have to add it into that file for it to work, and IMO a single PR for this change would be better. But as long as it gets added, I'm fine with it

Originally posted by @5chmidti in #117901 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
clang:frontend Language frontend issues, e.g. anything involving "Sema"
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants