Remove redundant specs from pyproject.toml #134
Conversation
|
Yes, I will add the fix. It should just be |
|
@matentzn I have seen the same in nfdi4cat/pid4cat-model but forgot to submit the fix also here. |
| @@ -29,7 +29,7 @@ jobs: | |||
| run: pipx install poetry | |||
|
|
|||
| - name: Install dependencies. | |||
| run: poetry install -E docs | |||
|
|
||
| dynamic = ["version"] | ||
|
|
||
| dependencies = [ | ||
| "linkml-runtime >=1.8.0", | ||
| "linkml-runtime >=1.1.24", |
There was a problem hiding this comment.
Is it really necessary to support such an ancient version of linkml runtime?
There was a problem hiding this comment.
Probably not. I just kept what was there.
| ] | ||
|
|
||
| [tool.poetry] | ||
| requires-poetry = ">=2.0" | ||
| version = "0.0.0" | ||
|
|
||
| [tool.poetry.dependencies] | ||
| python = "^3.9" |
There was a problem hiding this comment.
How does poetry determine now which version to use during poetry install?
There was a problem hiding this comment.
poetry env info tells what Poetry will use. Poetry will try first the version it was installed with but offers more control if needed (see managing evironments).
| ] | ||
|
|
||
| [tool.poetry] | ||
| requires-poetry = ">=2.0" | ||
| version = "0.0.0" | ||
|
|
||
| [tool.poetry.dependencies] |
There was a problem hiding this comment.
Removing this essentially removes poetry < 2 support, right?
There was a problem hiding this comment.
Yes. Did you see the tip in #129 to have both versions installed side by side?
There was a problem hiding this comment.
@matentzn Do you think this is something we're ready to do as a community?
There was a problem hiding this comment.
@amc-corey-cox i have no helpful opinion on the matter. ;)
| ] | ||
|
|
||
| [tool.poetry] | ||
| requires-poetry = ">=2.0" | ||
| version = "0.0.0" | ||
|
|
||
| [tool.poetry.dependencies] |
There was a problem hiding this comment.
@matentzn Do you think this is something we're ready to do as a community?
After the upgrade to poetry 2, the Python and linkml-runtime dependencies are declared at two places in
pyproject.toml. This removes the redundancy.It was just an oversight in #128.
poetry checkdoes not complain and the project setup and installation works fine even with the redundant spec as long as there is no contradiction.This also fixes the installation in the docs-related gh-actions (#133):
Closes #133