Skip to content

workflows/test_pages_build.yaml does not work in default setup #133

Closed
@matentzn

Description

@matentzn
Contributor

This line does not work with the default setup:

Maybe this is because the extras syntax has changed?

I added

[project.optional-dependencies]
docs = ["jinjanator>=24.4.0"]

To the toml file and it worked ok.

Activity

dalito

dalito commented on Feb 9, 2025

@dalito
Member

I was first surprised that adding "jinjanator" fixes it which is neither a direct nor indirect dependency of current linkml-project-cookiecutter. But it fixes the underlying problem that extras are no longer present (which makes poetry install -E docs fail) by adding an extra back.

The real fix is to replace poetry install -E docs by only poetry install as mkdocs (and its dependency jinja) gets installed as part of the development-dependency group which poetry includes by default since the group is not explicitly excluded from the default install with optional = true .

matentzn

matentzn commented on Feb 9, 2025

@matentzn
ContributorAuthor

Oh no I didn't mean to suggest adding jinjanator; just that the extras syntax was wrong!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

      Development

      Participants

      @dalito@matentzn

      Issue actions

        workflows/test_pages_build.yaml does not work in default setup · Issue #133 · linkml/linkml-project-cookiecutter