Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix infinite load more #13185

Merged

Conversation

AlexVelezLl
Copy link
Member

@AlexVelezLl AlexVelezLl commented Mar 11, 2025

Summary

  • Fix infinite load more in lessons/quizzes resource selection
    • In the fetch tree resources, we were incorrectly setting the results of the last topic data if we were loading more resources from the tree fetch
Compartir.pantalla.-.2025-03-11.13_16_48.mp4

References

Closes #13173.

Reviewer guidance

  1. Go to coach > lessons > manage resources
  2. Load any folder whose resource list is paginated.
  3. Check that there are no regressions neither browsing the resources in the resources tree nor inside folders that appear in search results

@github-actions github-actions bot added APP: Coach Re: Coach App (lessons, quizzes, groups, reports, etc.) DEV: frontend labels Mar 11, 2025
@rtibbles rtibbles self-assigned this Mar 12, 2025
Copy link
Member

@pcenov pcenov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @AlexVelezLl, I confirm that the issue described in #13173 is fixed now and I didn't observe any regressions.

Copy link
Member

@rtibbles rtibbles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code changes make sense, and manual QA checks out.

@rtibbles rtibbles merged commit 4f03ae5 into learningequality:develop Mar 12, 2025
38 checks passed
@AlexVelezLl AlexVelezLl deleted the fix-infinite-load-more branch March 12, 2025 19:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
APP: Coach Re: Coach App (lessons, quizzes, groups, reports, etc.) DEV: frontend
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Manage lesson resources - Clicking on "View more" loads the same resources infinitely
3 participants