Implement new questions replacement

[AlexVelezLl]

Summary

• Implement new manual questions replacement according to the specs
• Remove old question replacement component, and related methods.

Compartir.pantalla.-.2025-03-10.13_25_40.mp4

References

Closes part of #13108, auto-replace is out of scope of this PR

Reviewer guidance

• Go to coach/quizzes/create new quiz
• Add questions to the section either manually or randomly.
• Use the new "replace" button in the question accodion and replace the question with one/multiple questions in manual/random selection mode.
• Try replacing questions from different parts of the questions list and check that it works well in all cases

[github-actions]

Build Artifacts

Asset type	Download link
PEX file	kolibri-0.18.0a3.dev0_git.86.gec646434.pex
Windows Installer (EXE)	kolibri-0.18.0a3.dev0+git.86.gec646434-windows-setup-unsigned.exe
Debian Package	kolibri_0.18.0a3.dev0+git.86.gec646434-0ubuntu1_all.deb
Mac Installer (DMG)	kolibri-0.18.0a3.dev0+git.86.gec646434.dmg
Android Package (APK)	kolibri-0.18.0a3.dev0+git.86.gec646434-0.1.4-debug.apk
Raspberry Pi Image	kolibri-pi-image-0.18.0a3.dev0+git.86.gec646434.zip
TAR file	kolibri-0.18.0a3.dev0+git.86.gec646434.tar.gz
WHL file	kolibri-0.18.0a3.dev0+git.86.gec646434-py2.py3-none-any.whl

[marcellamaki]

@pcenov and @radinamatic this will be a top priority for testing tomorrow - i'll be starting code review now

[nucleogenesis]

Didn't see anything blocking - just added a question. Overall the code LGTM, but will leave approval to the assigned reviewers

[nucleogenesis]

Did you consider using splice instead of making a function? For whatever is passed in as baseArray you could do baseArray.splice(index, 0, itemsToInsert) - although it does mutate the array in place.

Not blocking as this looks good overall and I see you're doing checks on the passed index as well, it just got me thinking

[AlexVelezLl]

Oh I didnt 😅. I just refactored the function to use the splice making a copy of the baseArray instead and it looks so much cleaner. Thanks @nucleogenesis!

[pcenov]

1. After having added questions to a section if I select some or all of the questions the "Select all", "Replace" and "Delete" options are not working. Looking at Figma it seems that the "Replace" option should be removed but the other 2 should be functioning normally unless otherwise specified:

options-not-working.mp4

2. When I select a single question now it is possible to replace it with multiple other questions if there are available questions but at the same time I can't see a way of bulk replacing several of my questions - mentioning this as confusing and not very comfortable or intuitive.
3. In addition to the above point, after I have just added several questions as a replacement to the one I've selected, then the question list is not refreshed automatically and there's no snackbar message confirming the successful replacement:

replaced.or.not.mp4

4. When replacing questions I would expect the label of the button "Add N questions" to be changed to "Replace N questions". This is also valid for the title of the modal which is confusingly also labeled "Add questions to "Section 1". Lastly if I have already added the max number of questions when I try to replace 1 I am seeing the button "Add N questions" grayed out and labeled "Add 0 questions" while I would expect it to be "Replace 1 question":

add.0.mp4

5. If I switch off the manual selection it's not clear at all why I can't add additional questions:

the.button.remains.disabled.mp4

[AlexVelezLl]

Ah my apologies, I somehow messed things up with the version control and it seems that some changes were reverted 😅. Just pushed again the fix for 1 and 3.

For point 2: It wasnt supposed to be visible the bulk replace icon anymore. Now we can replace one question at a time. Knowing this, as a user, do you think that replacing one question with multiple quesitons is confusing? This is something we are still evaluating.

Points 4 and 5 are things that we can evaluate from the design perspective cc: @marcellamaki @jtamiace.

Just fyi: The reason why we cant save the selected resource in point 5 is because when we uncheck the manual selection mode, we set the number of questions to select to the default value: 10. And if the current resource doesnt have 10 available questions, then it will wait for another resource to be selected until we have 10 available questions in the pool. But we dont communicate this in any way, and I think for the question replacement workflow is a little more confusing because the users never see the questions number input because we dont open the modal in the settings page.

[pcenov]

Thanks @AlexVelezLl - I confirm that 1 is fixed now.
3 is partially fixed because there is still no snackbar message informing the user that the replacement was successful.

I was also able to identify the following issues:
6. For some reason the "Search" button is not working so we can't test the replacement of a question found by searching for it.
7. When in manual selection mode the link "N questions selected" brings the user to a page where the user can essentially do the same as on the previous page with the addition of the delete icon - so this should probably also be further discussed:

nquestionselected.mp4

[AlexVelezLl]

Hi @pcenov! Now I have fixed all the poings but 6 and 7. 6 is still in development Not anymore :) you can now click on the search button, and 7 is the expected behaviour for now.

Point 2 has been solved by setting a the max amount of questions to select equals to the number of questions being replaced, and we have added again the "replace" button in the bulk toolbar.

For point 5, now the user dont have a way to switch to random selection, so this shouldnt happen anymore in questions replacement :)