Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate kind arm64 testgrid config #13854

Closed
wants to merge 1 commit into from
+9 −5
Closed

Migrate kind arm64 testgrid config #13854

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Migrate kind arm64 testgrid config
@aojea
aojea committed Aug 12, 2019
commit 4665dd85ba48840eaded6f1b7ddf539a64476e8f
5 changes: 0 additions & 5 deletions config/testgrids/config.yaml
View file
Original file line number Diff line number Diff line change
@@ -303,8 +303,6 @@ test_groups:
- name: test_pull_request_crio_e2e_rhel
gcs_prefix: origin-federated-results/pr-logs/directory/test_pull_request_crio_e2e_rhel

- name: ci-kubernetes-kind-conformance-latest-1-14-arm64
gcs_prefix: k8s-conformance-kind-arm64-openlab/periodic-logs/ci-kind-integration-test-arm64
# cloud-provider-openstack e2e conformance tests
# name format: PR trigger ci-presubmit-${zuul-job-name}
# periodic strigger ci-periodic-${zuul-job-name}
@@ -702,9 +700,6 @@ dashboards:
- name: conformance-all
# entries are named $PROVIDER, $KUBERNETES_RELEASE
dashboard_tab:
- name: kind, v1.14 (dev, ARM64)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this should be in multiple dashboards in this file, if we're moving it, we should move them all or at least matching pairs

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we cut-paste the conformance dashboards to a separate kind-conformance file, then?

Copy link
Member Author

@aojea aojea Aug 13, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is the part I don´t get from the email announcing the change, is this file still valid?
if not, do I need to create all the folders for the other dashboards?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not fully up to date on the new world of managing testgrid tabs but as for kind:

Right now we ensure that the conformance-all entries generally match the other conformance-foo dashboards

The same kind tabs should be in both, whatever works best for managing that.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is the part I don´t get from the email announcing the change, is this file still valid?
if not, do I need to create all the folders for the other dashboards?

The file is currently valid as-is, and will be valid as any YAML file in this directory, split up however. We want to split up the testgrid tabs according to who knows about what, to make it all more manageable. (see #13541).

I don't know who owns the conformance-* dashboards. If it's an existing sig, I recommend a separate file in that folder. If it's someone else, then make a directory for them.

The conformance dashboards can all go in one file, unless that's too big, and then they can be divided up in multiple files.

description: Runs conformance tests using kubetest against latest kubernetes release-1.14 with a kubernetes-in-docker cluster on ARM64 platform
test_group_name: ci-kubernetes-kind-conformance-latest-1-14-arm64
- name: OpenStack, master (dev)
description: Runs conformance tests using kubetest against latest kubernetes master with cloud-provider-openstack
test_group_name: ci-periodic-cloud-provider-openstack-acceptance-test-e2e-conformance
9 changes: 9 additions & 0 deletions config/testgrids/kubernetes/sig-testing/config.yaml
View file
Original file line number Diff line number Diff line change
@@ -1,3 +1,8 @@
# Test Groups
test_groups:
- name: ci-kubernetes-kind-conformance-latest-1-14-arm64
gcs_prefix: k8s-conformance-kind-arm64-openlab/periodic-logs/ci-kind-integration-test-arm64

# Dashboard Group

dashboard_groups:
@@ -131,6 +136,10 @@ dashboards:
url: https://github.com/kubernetes/test-infra/compare/<start-custom-0>...<end-custom-0>

- name: sig-testing-kind
dashboard_tab:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we care much more about this being in the conformance-all and conformance-kind dashboards

- name: kind, v1.14 (dev, ARM64)
description: Runs conformance tests using kubetest against latest kubernetes release-1.14 with a kubernetes-in-docker cluster on ARM64 platform
test_group_name: ci-kubernetes-kind-conformance-latest-1-14-arm64

- name: sig-testing-maintenance
dashboard_tab: