Migrate kind arm64 testgrid config #13854
Conversation
k8s-ci-robot
added
cncf-cla: yes
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: aojea The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/assign @BenTheElder |
|
@aojea: GitHub didn't allow me to request PR reviews from the following users: ZhengZhenyu. Note that only kubernetes members and repo collaborators can review this PR, and authors cannot review their own PRs. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
This change removes a tab from |
Honestly, I'm a bit lost here 😅 , I'm just trying to "recover" the job in testgrid so I can check the results in the kind dashboard, but don't know exactly which one should I move. |
| @@ -131,6 +136,10 @@ dashboards: | |||
| url: https://github.com/kubernetes/test-infra/compare/<start-custom-0>...<end-custom-0> | |||
|
|
|||
| - name: sig-testing-kind | |||
| dashboard_tab: | |||
There was a problem hiding this comment.
we care much more about this being in the conformance-all and conformance-kind dashboards
| @@ -702,9 +700,6 @@ dashboards: | |||
| - name: conformance-all | |||
| # entries are named $PROVIDER, $KUBERNETES_RELEASE | |||
| dashboard_tab: | |||
| - name: kind, v1.14 (dev, ARM64) | |||
There was a problem hiding this comment.
this should be in multiple dashboards in this file, if we're moving it, we should move them all or at least matching pairs
There was a problem hiding this comment.
Can we cut-paste the conformance dashboards to a separate kind-conformance file, then?
There was a problem hiding this comment.
this is the part I don´t get from the email announcing the change, is this file still valid?
if not, do I need to create all the folders for the other dashboards?
There was a problem hiding this comment.
I'm not fully up to date on the new world of managing testgrid tabs but as for kind:
Right now we ensure that the conformance-all entries generally match the other conformance-foo dashboards
The same kind tabs should be in both, whatever works best for managing that.
There was a problem hiding this comment.
this is the part I don´t get from the email announcing the change, is this file still valid?
if not, do I need to create all the folders for the other dashboards?
The file is currently valid as-is, and will be valid as any YAML file in this directory, split up however. We want to split up the testgrid tabs according to who knows about what, to make it all more manageable. (see #13541).
I don't know who owns the conformance-* dashboards. If it's an existing sig, I recommend a separate file in that folder. If it's someone else, then make a directory for them.
The conformance dashboards can all go in one file, unless that's too big, and then they can be divided up in multiple files.
|
If the intent of this PR is to split apart the Testgrid config to the "new" way, then I can help with that. |
|
@chases2 thank you very much, should I close this PR? |
|
I think so? Let me know if #13894 is a split that makes sense to you. In particular, input on the OWNERS file would be great; I copied it from config/jobs/kubernetes-sigs/kind |
|
duplicate of #13894 |
Migrating the kind arm64 kind job to the new testgrid config structure
xref kubernetes-sigs/kind#188