Implement application template context at new generators. #15918
Conversation
| * Single absolute path or relative path(s) between the templates folder and template path. | ||
| * @return {string[]} | ||
| */ | ||
| async writeFiles(options) { |
There was a problem hiding this comment.
Can it be put in a dedicated files and called from there?
for example:
utils/generation/processing/template-processor.js // for ejsutils/generation/processing/file-processor.js // for svg, png, or other static filesutils/generation/processing/templates-processor.js // calling the two above
Ideally, if we could make the classes SOLID (including the S) we could get some new opportunity
There was a problem hiding this comment.
IMO this will make more complicated.
I will try to make writeFiles more linear.
| @@ -52,6 +51,9 @@ module.exports = class extends MixedChain { | |||
|
|
|||
| if (this.options.help) return; | |||
|
|
|||
| // Application context for templates | |||
| this.application = {}; | |||
There was a problem hiding this comment.
what about creating a dedicated object for this?
utils/generation/model/contexts/application-context.js
application = { baseName: undefined, baseFolder; undefined, ...}
There was a problem hiding this comment.
or in each generator if you prefer to keep them loosely coupled
There was a problem hiding this comment.
We are using javascript not typescript, I don't see the need for this.
There was a problem hiding this comment.
giving some guidance and a clear contract for anyone which want to know the attributes that are recognized by the generators.
But anyway as you mentioned, javascript is not so pojo oriented...
| @@ -58,7 +58,7 @@ module.exports.mixin = parent => | |||
| * @param {any} config - config to load config from | |||
| * @param {any} into - destination context to use default is context | |||
| */ | |||
| loadProjectNameConfig(config = this.jhipsterConfig, into = this) { | |||
| loadProjectNameConfig(into = this, config = this.jhipsterConfig) { | |||
| config = defaults({}, config, defaultConfig); | |||
There was a problem hiding this comment.
config = defaults({}, this.jhipsterConfig, defaultConfig)?
| * Single absolute path or relative path(s) between the templates folder and template path. | ||
| * @return {string[]} | ||
| */ | ||
| async writeFiles(options) { |
There was a problem hiding this comment.
IMO this will make more complicated.
I will try to make writeFiles more linear.
| @@ -52,6 +51,9 @@ module.exports = class extends MixedChain { | |||
|
|
|||
| if (this.options.help) return; | |||
|
|
|||
| // Application context for templates | |||
| this.application = {}; | |||
There was a problem hiding this comment.
We are using javascript not typescript, I don't see the need for this.
mshima
force-pushed
the
skip_ci-modular_context
branch
from
a42893c to
d8a39b0
Compare
prepareDerived*Propertiestoprepare*DerivedPropertiesPlease make sure the below checklist is followed for Pull Requests.
When you are still working on the PR, consider converting it to Draft (bellow reviewers) and adding
skip-cilabel, you can still see CI build result at your branch.