Improve new generators. #15883
Improve new generators. #15883
Conversation
mshima
force-pushed
the
skip_ci-priorities
branch
from
ac1d23c to
dda5c13
Compare
|
Way cleaner than what we were before for sure :-). Perfect! |
| registerSpringBootOptions() { | ||
| this.jhipsterOptions(options); | ||
| getSpringBootOptions() { | ||
| return options; |
There was a problem hiding this comment.
Isn't it the occasion to set scopes for options? ApplicationScope (or platformscope), ModuleScope, EntityScope and entityKeyScope?
There was a problem hiding this comment.
They cannot mix with applications and I hope mixins will not be required for entities.
What do you consider a platform scope?
From my point of view, it's specific to a technology, and are hierarchical instead of polymorphic.
By changing getSpringBootOptions to getSpringBootApplicationOptions, it would make sense to change the entire mixin api to *Application*.
There was a problem hiding this comment.
Monitoring and service registry? I think that also docker-compose, kubenretes, openshift, ... Any platform configuration could be part of the platformconfig.
And very good idea for the Application mixins ;-)
There was a problem hiding this comment.
We should create platform generator with those configs.
There was a problem hiding this comment.
yes, but in addition I was thinking about populating a dedicated scope object for each kind of options instead of injecting them in 'this'.
mshima
force-pushed
the
skip_ci-priorities
branch
from
c9f679b to
5bcabc0
Compare
mshima
force-pushed
the
skip_ci-priorities
branch
from
5bcabc0 to
44491ce
Compare
_from blueprint api related to Provide a custom prefix for generator tasks #15784.Please make sure the below checklist is followed for Pull Requests.
When you are still working on the PR, consider converting it to Draft (bellow reviewers) and adding
skip-cilabel, you can still see CI build result at your branch.