Port mapping

[jwhitcraft]

This is to finish up the port mapping ticket in #135.

I added the help documents, and i can fix the other issue if @carlossg and provide guidance on how it should be fixed.

[carlossg]

the way jenkins (de)serializes is a bit confusing. In upgrades this.ports will be null because the field is not in the xml config.
What you want is to guard against that, so just remove final (I don't think there's any reason to have it) and do this.ports=ports

[jwhitcraft]

Sounds good, I'll update it in a few and push it up.

[jwhitcraft]

@carlossg fixed.

[carlossg]

no need to check for null now

public void setPorts(List<PortMapping> ports) {
  this.ports = ports;
}

[carlossg]

I am merging it because it's been around for long, but it would be nice to have a pipeline test

[negz]

@carlossg Do you have a feeling of when the next release will be? No pressure - just wondering whether I should wait or build from master for now.

[carlossg]

no pressure taken ;)
I need testers for #157 to +1 it so I know it's not breaking everything

[herr-bubu]

Hey Guys,
I was trying to use this plugin and it's great (in most cases) :) but I've got a problem with it.
I'm trying to set up two different Postgres dbs on on Pod, so I had to map ports because my postgres-docker exposes a port 5432 by default.
But it looks like below. It shows that this particular port is already taken.

parallel(
    failFast: true,
    "Selenium": {
      podTemplate(label: "${label}", yaml: """
        apiVersion: v1
        kind: Pod
        spec:
          serviceAccountName: ${serviceAccount}
          securityContext:
            runAsUser: 1000
            fsGroup: 1000
          containers:
          - name: postgres-main
            image: postgres:10
            ports:
            - containerPort: 5432
              hostPort: 6432
            securityContext: 
              runAsUser: 0    
          - name: postgres-chat
            image: postgres:10
            - containerPort: 5432
              hostPort: 6432
            securityContext: 
              runAsUser: 0
        """
      ) { }

Unfortunately I get this:

PostgreSQL init process complete; ready for start up.

2018-12-22 00:15:00.608 UTC [1] LOG:  could not bind IPv4 address "0.0.0.0": Address already in use
2018-12-22 00:15:00.608 UTC [1] HINT:  Is another postmaster already running on port 5432? If not, wait a few seconds and retry.
2018-12-22 00:15:00.608 UTC [1] LOG:  could not bind IPv6 address "::": Address already in use
2018-12-22 00:15:00.608 UTC [1] HINT:  Is another postmaster already running on port 5432? If not, wait a few seconds and retry.
2018-12-22 00:15:00.608 UTC [1] WARNING:  could not create listen socket for "*"
2018-12-22 00:15:00.608 UTC [1] FATAL:  could not create any TCP/IP sockets
2018-12-22 00:15:00.608 UTC [1] LOG:  database system is shut down