Implement Port Mapping #135

derfred · 2017-02-18T02:05:49Z

This adds the capability to expose ports on the pods like this:

podTemplate(label: 'mypod', containers: [
    containerTemplate(
        name: 'mariadb', 
        ports: [portMapping(name: 'mysql', containerPort: 3306)]
    ),
    ...
],

carlossg

Can you add the UI for the settings form, not just for pipeline?

carlossg · 2017-02-18T13:06:11Z

src/main/java/org/csanchez/jenkins/plugins/kubernetes/ContainerTemplate.java

+
+    @DataBoundSetter
+    public void setPorts(List<PortMapping> ports) {
+        this.ports.addAll(ports);


this.ports may be null

by this logic @carlossg the setEnvVars calls could also be null and fail as it just does this

public void setEnvVars(List<ContainerEnvVar> envVars) { this.envVars.addAll(envVars); }

I was thinking the same.

it's only on upgrades, maybe envVars was there from the beginning

Because ports didn't exist, when deserializing the previous version configuration jenkins will set ports=null

@carlossg, I upgrade to a version of the plugin with this patched it and I didn't see any errors or nothing anything once jenkins was up again and running jobs.

jwhitcraft · 2017-03-28T18:59:53Z

@derfred any update on this? I've recently come into the need of having ports be exposed for e2e testing things.

derfred · 2017-03-29T15:18:32Z

@carlossg I have added the UI for exposing the ports.

jwhitcraft · 2017-03-29T20:53:14Z

README.md

@@ -83,6 +83,7 @@ The `containerTemplate` is a template of container that will be added to the pod
 * **command** The command the container will execute.
 * **args** The arugments passed to the command.
 * **ttyEnabled** Flag to mark that tty should be enabled.
+* **ports** Expose ports on the container.


@derfred this works great, the only thing that you may want to add to the readme is to outline that you access a port that is open on another container you need to use 127.0.0.1 for the url, as doing it name based is not working for me.

@jwhitcraft in what scenario are you using it? Because I am trying to run some tests with a mariadb database and getting connection refused when trying to connect. My pod template is exactly as the one on readme. I tried to connect to mysql cli from within the container as well, and I get a ´Can't connect to local MySQL server through socket ´ error (commented in the PR as well).

Found the solution, described in the PR discussion

gytisgreitai · 2017-04-20T11:34:04Z

@carlossg can we get this merged?

carlossg

thanks, added a comment about setPorts

It also needs the help blurbs for the UI under https://github.com/jenkinsci/kubernetes-plugin/tree/master/src/main/resources/org/csanchez/jenkins/plugins/kubernetes and for pipeline in https://github.com/jenkinsci/kubernetes-plugin/tree/master/src/main/resources/org/csanchez/jenkins/plugins/kubernetes/pipeline/PodTemplateStep

carlossg · 2017-04-20T11:37:45Z

src/main/java/org/csanchez/jenkins/plugins/kubernetes/ContainerTemplate.java

+    public void setPorts(List<PortMapping> ports) {
+        if (ports != null) {
+            this.ports.addAll(ports);
+        }


if it is null then you are doing nothing

What should be done if the value is null? this.ports is already the list as defined above. In my testing of this, this works fine.

I missread. But shouldn't be just

this.ports = ports

otherwise you are adding ports all the time to the existing ones, not clearing up

@carlossg since the field is final you just can't set it like that.

I'm chaning it to this

this.ports.clear(); this.ports.addAll(ports);

It would also seem that setEnvVars falls into the same problem, but that's another bug.

I've added the fix to #165

I'll comment there

jwhitcraft · 2017-05-05T14:05:38Z

@derfred any chance of finishing up this?

jwhitcraft · 2017-06-07T15:40:28Z

@derfred if you don't have time to fix this, i may cherry-pick your commits in and fix what @carlossg suggested. We really need this in before the next release is cut so we can stop compiling our own.

carlossg · 2017-06-08T16:02:30Z

superseded by #165

andriosrobert · 2017-07-11T21:36:28Z

I'm getting java.lang.NoSuchMethodError: No such DSL method 'portMapping' found among steps at repo checkout time, when trying to use it on a scripted pipeline, using the exact same definition from the mariadb container template in the readme file.

Jenkins is running on a Kubernetes cluster on aws.
plugin version: 0.11
jenkins version: 2.7.2
Any clue on why is it not working?

carlossg · 2017-07-12T17:26:30Z

it will be released in 0.12

andriosrobert · 2017-08-02T23:37:07Z

Im trying to run some application tests using mariadb container and portaMapping, but it does not work for me using neither using 127.0.0.1, localhost or 0.0.0.0. When trying to access mysql cli from within the cointainer I get:
ERROR 2002 (HY000): Can't connect to local MySQL server through socket '/var/run/mysqld/mysqld.sock' (111)
My template looks exactly the same as the one described on README.md
Any help would be welcome :)

andriosrobert · 2017-08-28T15:51:18Z

Found the solution that day, just explaining so that other people facing the same issue could benefit from it. Inspecting the container created by Kubernetes, I realized that the container template for Mariadb in the readme does not work, it has two errors:

command: The command for the Mariadb container to start should be mysqld, and not cat as it is in the readme. It indicated the Mariadb deamon binary, without which the container would start without a deamon
args: The arguments should not be empty as it is in the readme, once the Mariadb image uses a shell entrypoint (docker-entrypoint.sh) in order to setup the database, without which a database setup would not work

Im filling a small PR to fix this

derfred added 2 commits February 17, 2017 16:42

add port mapping

fad13e1

update readme

7748ce1

carlossg reviewed Feb 18, 2017

View reviewed changes

add UI for exposing ports

1d98030

jwhitcraft reviewed Mar 29, 2017

View reviewed changes

add guard for upgrades

e25eadd

carlossg requested changes Apr 20, 2017

View reviewed changes

jwhitcraft mentioned this pull request Jun 8, 2017

Port mapping #165

Merged

carlossg closed this Jun 8, 2017

derfred deleted the port_mapping branch July 12, 2017 17:51

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Implement Port Mapping #135

Implement Port Mapping #135

derfred commented Feb 18, 2017

carlossg left a comment

carlossg Feb 18, 2017

jwhitcraft Mar 28, 2017

derfred Mar 29, 2017

carlossg Apr 3, 2017

jwhitcraft Apr 5, 2017

jwhitcraft commented Mar 28, 2017

derfred commented Mar 29, 2017

jwhitcraft Mar 29, 2017

andriosrobert Aug 3, 2017

andriosrobert Aug 28, 2017 •

edited

Loading

gytisgreitai commented Apr 20, 2017

carlossg left a comment

carlossg Apr 20, 2017

jwhitcraft Jun 8, 2017

carlossg Jun 8, 2017 •

edited

Loading

jwhitcraft Jun 8, 2017 •

edited

Loading

carlossg Jun 8, 2017

jwhitcraft commented May 5, 2017

jwhitcraft commented Jun 7, 2017

carlossg commented Jun 8, 2017

andriosrobert commented Jul 11, 2017 •

edited

Loading

carlossg commented Jul 12, 2017

andriosrobert commented Aug 2, 2017

andriosrobert commented Aug 28, 2017 •

edited

Loading

Implement Port Mapping #135

Implement Port Mapping #135

Conversation

derfred commented Feb 18, 2017

carlossg left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jwhitcraft commented Mar 28, 2017

derfred commented Mar 29, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

andriosrobert Aug 28, 2017 • edited Loading

Choose a reason for hiding this comment

gytisgreitai commented Apr 20, 2017

carlossg left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

carlossg Jun 8, 2017 • edited Loading

Choose a reason for hiding this comment

jwhitcraft Jun 8, 2017 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jwhitcraft commented May 5, 2017

jwhitcraft commented Jun 7, 2017

carlossg commented Jun 8, 2017

andriosrobert commented Jul 11, 2017 • edited Loading

carlossg commented Jul 12, 2017

andriosrobert commented Aug 2, 2017

andriosrobert commented Aug 28, 2017 • edited Loading

andriosrobert Aug 28, 2017 •

edited

Loading

carlossg Jun 8, 2017 •

edited

Loading

jwhitcraft Jun 8, 2017 •

edited

Loading

andriosrobert commented Jul 11, 2017 •

edited

Loading

andriosrobert commented Aug 28, 2017 •

edited

Loading