Solve random dark pane over video playing in fullscreen mode #218
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dkanada
approved these changes
Apr 1, 2019
cvium
approved these changes
Apr 1, 2019
|
Retargeted against release branch as RC hotfix. |
JustAMan
approved these changes
Apr 1, 2019
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses a bug that supposedly renders a dark pane over the video when playing.
I managed to replicate this problem when one file ends and the next one starts playing by itselt, for a specific file. This issue is caused because the property
playOptionsof the item being playing is missing sometimes. The dark pane shows when the property fullscreen represents a false result to a condition. This condition represents when a video is playing but not in the full viewport space available. To mitigate this problem, fallback points has been added when getting playOptions with an existing function for the effect.I already tested these changes with jf-android.