Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dark overlay staying on #90

Closed
Numline1 opened this issue Dec 28, 2018 · 9 comments
Closed

Dark overlay staying on #90

Numline1 opened this issue Dec 28, 2018 · 9 comments
Labels
bug Something isn't working

Comments

@Numline1
Copy link

Hello!

First of all, thanks for all the great work done on Jellyfin! I've noticed an issue over the past few days since I started using this fork.

The modal popup overlay tends to stay on over the player in some situations. By overlay I mean the dark cover that appears when you perform an action in the player menu, like picking subtitle or displaying the 'stats for nerds'.

Example:

image

I've noticed this behaviour in both Safari and Chrome. In this case, I was watching a video for a few minutes, decided to pick English subtitles by clicking the "CC" button at the bottom. After i did that, the video started re-encoding, as it should, the series poster appeared and once the video started playing a few seconds later, the black overlay was there, as seen in the picture.

This dissapears after reload/reselecting the episode from home screen, which basically reloads the players/page.

I did some digging and found out which div causes the issue (it went away after I set "display: none" property on it, see screenshot below.

image

I hope it helps with debugging. Thanks in advance!

@joshuaboniface
Copy link
Member

Curiously I used to get this on Emby too but I could never reliably reproduce it.

@Numline1
Copy link
Author

You are very correct, I couldn't reproduce this again, I assume there's something that doesn't close the backdrop div. Sadly, I'm clueless when it comes to C#, so that's all I can provide. I tried displaying some of the modals, like Stats for nerds or Playback settings, then changing the subtitle, but neither made it happen again :(

@JustAMan
Copy link
Contributor

I doubt it has anything to do with c#, looks like purely frontend issue to me.

@Numline1
Copy link
Author

I'm not claiming it's an issue related to C# code, I'm just saying I have no idea how the templating and FE/BE connection works in this project :)

@Zephilinox
Copy link

I have the same issue, for me it happens when turning off subtitles. I added this filter to adblocker which is an okay solution for now:

localhost##.withBackdrop.backgroundContainer-transparent.backgroundContainer

@anthonylavado anthonylavado transferred this issue from jellyfin/jellyfin Jan 27, 2019
@sparky8251
Copy link
Contributor

If someone can provide instructions that reliably produce this I can take a crack at it. I occasionally get it as well, but I haven't been able to find an exacerbating factor or reliable means of causing it.

@sparky8251 sparky8251 added the bug Something isn't working label Feb 6, 2019
@Numline1
Copy link
Author

Numline1 commented Feb 7, 2019

Not really? I didn't have that issue in a while. I feel like it was happening when I was on vacation by the end of 2018 with shitty internet. When I opened the "Stats for nerds" and the video started buffering, sometimes it stayed. Since I've been back home, the video never buffers, so that's probably why it stopped happening.

This might be a start, but I'm not sure whether this is the exact way of how to reproduce it or more of a anecdotal coincidence.

// + There's also a situation example in my original post. It probably has something to do with buffering and the overlay not going away afterwards.

@Bond-009
Copy link
Member

Bond-009 commented Apr 1, 2019

Didn't this get fixed by #218?

@dkanada
Copy link
Member

dkanada commented May 20, 2019

@Bond-009 is correct

@dkanada dkanada closed this as completed May 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

7 participants