This repository was archived by the owner on Jan 13, 2023. It is now read-only.
Fixes #288 Remove tips from get_inclusion_states
#297
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
todofixthis
approved these changes
Jan 30, 2020
Comment on lines
-119
to
+89
| # I bring scientists, you bring a rock star. | ||
| 'foo': 'bar', | ||
| # 'tips' deprecated in IRI 1.9.0 | ||
| 'tips': [self.trytes1] | ||
| }, | ||
|
|
||
| { | ||
| 'foo': [f.FilterMapper.CODE_EXTRA_KEY], | ||
| 'tips': [f.FilterMapper.CODE_EXTRA_KEY], |
- `tips` parameter is no longer in use from IRI 1.8.6. - GetInclusionStates API endpoint returns if tx is confirmed since the last milestone. - `get_latest_iclusion_states` extended API becomes irrelevant, remove in this commit. - Modify components using it, rely on `get_inclusion_states`. - Update tests. - Update documentation.
lzpap
force-pushed
the
remove_tips_from_gis
branch
from
23d5c05 to
24443f2
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solves #288
Description
tipsparameter forget_inclusion_statesis no longer in use from IRI 1.8.6.GetInclusionStatesAPI endpoint returns, if tx is confirmed since the last milestone.get_latest_inclusion_statesextended API becomes irrelevant, remove in this commit.get_inclusion_states.