Skip to content
This repository was archived by the owner on Jan 13, 2023. It is now read-only.

Remove tips parameter from get_inclusion_states API call #288

Closed
lzpap opened this issue Jan 15, 2020 · 0 comments
Closed

Remove tips parameter from get_inclusion_states API call #288

lzpap opened this issue Jan 15, 2020 · 0 comments
Labels
deprecation Removal of obsolete functionality. IRI v1.8.6 Changes required for IRI v1.8.6

Comments

@lzpap
Copy link
Member

lzpap commented Jan 15, 2020 •
edited
Loading

Description

With the next IRI release v1.8.6, tips parameter will be removed from getInclusionStates API endpoint. See iotaledger/iri#1350 and iotaledger/iri#1685 for more info.

IRI will only check if the tx was approved by a milestone. If clients still send the parameter it should be ignored.

Changes needed

  • Remove the parameter in PyOTA from get_inclusion_states() and getInclusionStatesCommand.
  • Update test case for the command.
  • Update the documentation.
@lzpap lzpap added help wanted deprecation Removal of obsolete functionality. labels Jan 15, 2020
lzpap added a commit to lzpap/pyota that referenced this issue Jan 29, 2020
@lzpap
Fixes iotaledger#288 Remove tips from get_inclusion_states
23d5c05 
- `tips` parameter is no longer in use from IRI 1.9.0.
- GetInclusionStates API endpoint returns if tx is confirmed
  since the last milestone.
- `get_latest_iclusion_states` extended API becomes irrelevant,
  remove in this commit.
- Modify components using it, rely on `get_inclusion_states`.
- Update tests.
- Update documentation.
@lzpap lzpap mentioned this issue Jan 29, 2020
Merged
@lzpap lzpap added IRI v1.8.6 Changes required for IRI v1.8.6 and removed help wanted labels Mar 2, 2020
@lzpap lzpap mentioned this issue Mar 18, 2020
Closed
lzpap added a commit that referenced this issue May 29, 2020
@lzpap
Merge pull request #297 from lzpap/remove_tips_from_gis
424c894 
Fixes #288 Remove tips from `get_inclusion_states`
@lzpap lzpap closed this as completed in 24443f2 Jun 4, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
deprecation Removal of obsolete functionality. IRI v1.8.6 Changes required for IRI v1.8.6
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@lzpap