Updated XSCreator.py for PHISICS interface #810
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The scattering cross section was not accepted as a variable (although the RAVEN manual was stating so, and PHISICS can generate scaling factors relative to the scattering XS). The scattering XS variable was simply missing in the interface.
The nested loops were removed to accelerate the routine
alfoa
commented
Oct 2, 2018
| @@ -152,7 +152,7 @@ def fileReconstruction(self,deconstructedDict): | |||
| Converts the formatted dictionary -> {'XS|FUEL1|U235|FISSION|1':1.30, 'XS|FUEL2|U238|ABS|2':4.69} | |||
| into a dictionary of dictionaries that has the format -> {'XS':{'FUEL1':{'U235':{'FISSION':{'1':1.30}}}}, 'FUEL2':{'U238':{'ABS':{'2':4.69}}}} | |||
| @ In, deconstructedDict, dictionary, dictionary of perturbed variables | |||
| @ Out, leanReconstructedDict, dict, nested dictionary of perturbed variables | |||
| @ Out, leanReconstructedDict, dictionary, nested dictionary of perturbed variables | |||
| @@ -134,7 +134,7 @@ def formatXS(self,reaction): | |||
| else: | |||
| raise IOError('the type of cross section '+reaction+' cannot be processed. Refer to manual for available reactions.') | |||
| return reactionTemplated | |||
|
|
|||
There was a problem hiding this comment.
remove trailing spaces...
run the script ./developer_tools/delete_trailing_whitespace.sh framework
| for typeKey, value in deconstructedDict.iteritems(): | ||
| if typeKey in pertDictSet: | ||
| keyWords = typeKey.split('|') | ||
| reconstructedDict[keyWords[0]][keyWords[1]][keyWords[2]][keyWords[3]][keyWords[4]][keyWords[5]][keyWords[6]] = value | ||
| leanReconstructedDict = self.cleanEmpty(reconstructedDict) | ||
| return leanReconstructedDict | ||
| return leanReconstructedDict |
alfoa
requested review from
aalfonsi and
wangcj05
and removed request for
aalfonsi
|
@wangcj05 Since i added some modifications, I can not review this PR. |
wangcj05
reviewed
Oct 2, 2018
| @@ -129,6 +129,8 @@ def formatXS(self,reaction): | |||
| reactionTemplated = 'nalphaXS' | |||
| elif reaction == 'NGXS': | |||
| reactionTemplated = 'ngXS' | |||
| elif reaction == 'SCATTERINGXS': | |||
| reactionTemplated = 'ScatteringXS' | |||
There was a problem hiding this comment.
test case to cover this modification?
|
In addition, why all these commits are showing in this PR? |
alfoa
added
task
|
@aalfonsi should we close this PR? |
|
yes lets close it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
What issue does this change request address? (Use "#" before the issue to link it, i.e., #42.)
#611
What are the significant changes in functionality due to this change request?
Acceleration of parsing input
For Change Control Board: Change Request Review
The following review must be completed by an authorized member of the Change Control Board.
<internalParallel>to True.