Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

External Contribution - New Code Interface #611

Closed
5 of 10 tasks
alfoa opened this issue Apr 13, 2018 · 0 comments
Closed
5 of 10 tasks

External Contribution - New Code Interface #611

alfoa opened this issue Apr 13, 2018 · 0 comments
Labels
archive To archive the feature requests or PRs when there are no further developments external interfaces priority_minor task This tag should be used for any new capability, improvement or enanchment

Comments

@alfoa
Copy link
Collaborator

alfoa commented Apr 13, 2018

This issue is a floating issue that must be referenced in any Pull Request performed by External Entities (e.g. External Developers/Contributors), when a new Code Interface (i.e. RAVEN-External Code coupling) is created.

Referencing to this issue, the external contributor allows the RAVEN team and INL to redistribute the contribution along with the RAVEN code.


For Change Control Board: Issue Review

This review should occur before any development is performed as a response to this issue.

  • 1. Is it tagged with a type: defect or improvement?
  • 2. Is it tagged with a priority: critical, normal or minor?
  • 3. If it will impact requirements or requirements tests, is it tagged with requirements?
  • 4. If it is a defect, can it cause wrong results for users? If so an email needs to be sent to the users.
  • 5. Is a rationale provided? (Such as explaining why the improvement is needed or why current code is wrong.)

For Change Control Board: Issue Closure

This review should occur when the issue is imminently going to be closed.

  • 1. If the issue is a defect, is the defect fixed?
  • 2. If the issue is a defect, is the defect tested for in the regression test system? (If not explain why not.)
  • 3. If the issue can impact users, has an email to the users group been written (the email should specify if the defect impacts stable or master)?
  • 4. If the issue is a defect, does it impact the latest stable branch? If yes, is there any issue tagged with stable (create if needed)?
  • 5. If the issue is being closed without a merge request, has an explanation of why it is being closed been provided?
@alfoa alfoa added priority_minor task This tag should be used for any new capability, improvement or enanchment external interfaces labels Apr 13, 2018
@jbae11 jbae11 mentioned this issue Apr 13, 2018
8 tasks
@MagresTR MagresTR mentioned this issue Apr 13, 2018
8 tasks
@EmeraldRyan EmeraldRyan mentioned this issue Jul 15, 2019
9 tasks
@wangcj05 wangcj05 added the archive To archive the feature requests or PRs when there are no further developments label Feb 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
archive To archive the feature requests or PRs when there are no further developments external interfaces priority_minor task This tag should be used for any new capability, improvement or enanchment
Projects
None yet
Development

No branches or pull requests

2 participants