Add munkm feedback to JOSS paper #649
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
TODO: manually close #433 as this isn't merging into develop. |
tjlaboss
requested changes
Feb 3, 2025
10 tasks
|
Draft compilation. |
tjlaboss
requested changes
Feb 10, 2025
tjlaboss
approved these changes
Feb 12, 2025
|
@munkm, this is the other PR. Could you review this as well as part of the PyOpenSci review? |
32 tasks
|
Will do!!! Thanks for tagging me! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist for MontePy
Description
This is for the feedback in #646 from the PyOpenSci review that is related to the joss paper as those shouldn't be merged into develop. This is ready for review by @munkm now.
Fixes #646, Fixes #433.
General Checklist
The code follows the standards outlined in the development documentation.I have added tests that prove my fix is effective or that my feature works (if applicable).Documentation Checklist
I have documented all added classes and methods.For infrastructure updates, I have updated the developer's guide.For significant new features, I have added a section to the getting started guide.First-Time Contributor Checklist
pyproject.tomlif you wish to do so.Additional Notes for Reviewers
Ensure that:
The submitted code is consistent with the merge checklist outlined here.The PR covers all relevant aspects according to the development guidelines.100% coverage of the patch is achieved, or justification for a variance is given.📚 Documentation preview 📚: https://montepy--649.org.readthedocs.build/en/649/