Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not warn about comments that go over the line length #188

Open
MicahGale opened this issue Nov 21, 2023 · 5 comments · May be fixed by #608
Open

Do not warn about comments that go over the line length #188

MicahGale opened this issue Nov 21, 2023 · 5 comments · May be fixed by #608
Assignees
Labels
feature request An issue that improves the user interface. good first issue Good for newcomers low priority
Milestone

Comments

@MicahGale
Copy link
Collaborator

In GitLab by @tjlaboss on Nov 21, 2023, 11:10

Beyond the maximum line length (generally 80 or 128 characters), MCNP stops reading. Everything is effectively a comment.

Therefore, it is not a problem if comments go beyond the maximum line length. The LineOverRunWarning for anything part of a comment can be disabled.

@MicahGale
Copy link
Collaborator Author

Fair enough.

@MicahGale
Copy link
Collaborator Author

Food for thought: do overran comments get parroted to the output?

@MicahGale
Copy link
Collaborator Author

In GitLab by @tjlaboss on Nov 28, 2023, 09:12

No, it simply stops reading at the character limit. A feature of the FORTRAN READ() function.

@MicahGale
Copy link
Collaborator Author

In that case I can see there being scenarios where it would be helpful to still raise the warning.

Maybe what we could do is make a separate warning for comments that is suppressed by default, and let users enable it?

I think in general you're right the default should to be silently ignore this issue.

@MicahGale
Copy link
Collaborator Author

changed time estimate to 1d

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request An issue that improves the user interface. good first issue Good for newcomers low priority
Projects
None yet
2 participants