Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: adding quorum multip test ledger Dockerfile #1234

Merged

Conversation

travis-payne
Copy link

@travis-payne travis-payne commented Aug 17, 2021

This code allows for building of the a quorum multi party docker image that allows for private transactions to be tested.

Related to #951

Signed-off-by: Travis Payne [email protected]

@codecov-commenter
Copy link

codecov-commenter commented Aug 17, 2021

Codecov Report

Merging #1234 (f742a7c) into main (4c2b5db) will increase coverage by 0.47%.
The diff coverage is 71.34%.

❗ Current head f742a7c differs from pull request most recent head 919036d. Consider uploading reports for the commit 919036d to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1234      +/-   ##
==========================================
+ Coverage   71.71%   72.18%   +0.47%     
==========================================
  Files         270      272       +2     
  Lines        9411     9772     +361     
  Branches     1114     1179      +65     
==========================================
+ Hits         6749     7054     +305     
- Misses       2087     2099      +12     
- Partials      575      619      +44     
Impacted Files Coverage Δ
...erver/src/main/typescript/config/config-service.ts 74.41% <ø> (ø)
...src/main/typescript/prometheus-exporter/metrics.ts 100.00% <ø> (ø)
...src/main/typescript/prometheus-exporter/metrics.ts 100.00% <ø> (ø)
...src/main/typescript/prometheus-exporter/metrics.ts 100.00% <ø> (ø)
...typescript/plugin-keychain-vault-remote-adapter.ts 61.53% <0.00%> (-2.57%) ⬇️
...src/main/typescript/prometheus-exporter/metrics.ts 100.00% <ø> (ø)
...pescript/generated/openapi/typescript-axios/api.ts 62.98% <ø> (ø)
...src/main/typescript/prometheus-exporter/metrics.ts 100.00% <ø> (ø)
...ypescript/web-services/invoke-contract-endpoint.ts 66.66% <0.00%> (ø)
...ypescript/web-services/run-transaction-endpoint.ts 66.66% <0.00%> (ø)
... and 40 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d4af647...919036d. Read the comment docs.

@travis-payne travis-payne force-pushed the quorum-multi-party-ledger branch from 0408d1e to 9eafdf0 Compare August 20, 2021 15:38
@travis-payne travis-payne force-pushed the quorum-multi-party-ledger branch from 9eafdf0 to 44c265e Compare August 20, 2021 15:41
@travis-payne travis-payne requested a review from petermetz August 24, 2021 15:38
Copy link
Contributor

@petermetz petermetz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@travis-payne Please make sure to publish the image to the official repo with a fully qualified tag/version if not already (I may have already asked the same thing a few days ago).

@petermetz petermetz merged commit 02fa383 into hyperledger-cacti:main Aug 26, 2021
@petermetz petermetz deleted the quorum-multi-party-ledger branch August 26, 2021 21:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants