Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(quorum): Add private transaction support #951

Closed
TonyRowntree opened this issue May 10, 2021 · 1 comment · Fixed by #2293
Closed

feat(quorum): Add private transaction support #951

TonyRowntree opened this issue May 10, 2021 · 1 comment · Fixed by #2293
Labels
enhancement New feature or request Quorum
Milestone
v0.10.0

Comments

@TonyRowntree
Copy link
Contributor

TonyRowntree commented May 10, 2021 •
edited
Loading

Is your feature request related to a problem? Please describe.

Feature request: I need to be able to issue private transactions to a Quorum ledger via the Cactus API client.

Describe the solution you'd like

  1. Either a separate endpoint next to the current POST /run-transaction one or as an extension of it. Not yet sure which one is more feasible/makes more sense.
  2. Test coverage for the new feature
  3. Private transactions must not be logged by Cactus for obvious reasons.
  4. Documentation to explain specifically that this is not a privacy preserving feature, it only allows access to the pre-existing Quorum APIs as-is

Describe alternatives you've considered

Nothing. There is no doubt in my mind that we need this feature.

Additional context

Here's the Quorum documentation regarding private transactions:
https://docs.goquorum.consensys.net/en/stable/Concepts/Privacy/PrivateAndPublic/

cc: @takeutak @sfuji822 @jonathan-m-hamilton @petermetz @kikoncuo @travis-payne
@TonyRowntree TonyRowntree self-assigned this May 10, 2021
@TonyRowntree TonyRowntree added this to the v0.5.0 milestone May 10, 2021
@TonyRowntree TonyRowntree added enhancement New feature or request Quorum labels May 10, 2021
@petermetz petermetz modified the milestones: v0.5.0, v0.6.0 May 19, 2021
@petermetz petermetz modified the milestones: v0.6.0, v0.7.0 Jul 20, 2021
travis-payne pushed a commit to travis-payne/cactus that referenced this issue Jul 22, 2021
feat: adding more tests for besu private transactions
3fb94b2 
Closes: hyperledger-cacti#951
Signed-off-by: Travis Payne <[email protected]>
@petermetz petermetz modified the milestones: v0.7.0, v0.8.0 Aug 10, 2021
@petermetz petermetz modified the milestones: v0.8.0, v0.9.0 Aug 17, 2021
@travis-payne travis-payne mentioned this issue Aug 20, 2021
Merged
travis-payne pushed a commit to travis-payne/cactus that referenced this issue Aug 20, 2021
test: adding quorum mp test ledger dockerfile
44c265e 
Related to hyperledger-cacti#951

Signed-off-by: Travis Payne <[email protected]>
petermetz pushed a commit that referenced this issue Aug 26, 2021
@petermetz
test: adding quorum mp test ledger dockerfile
02fa383 
Related to #951

Signed-off-by: Travis Payne <[email protected]>
@petermetz petermetz modified the milestones: v0.9.0, v0.10.0 Sep 2, 2021
@travis-payne travis-payne mentioned this issue Sep 15, 2021
Closed
travis-payne pushed a commit to travis-payne/cactus that referenced this issue Sep 15, 2021
@petermetz
feat(quorum): private transaction support
5e57b11 
fixes hyperledger-cacti#951
travis-payne pushed a commit to travis-payne/cactus that referenced this issue Sep 15, 2021
@petermetz
feat(quorum): private transaction support
fed1aff 
fixes hyperledger-cacti#951

Signed-off-by: Travis Payne <[email protected]>
travis-payne pushed a commit to travis-payne/cactus that referenced this issue Sep 29, 2021
@petermetz
feat(quorum): private transaction support
493e20d 
fixes hyperledger-cacti#951

Signed-off-by: Travis Payne <[email protected]>
@petermetz
Copy link
Contributor

https://chat.hyperledger.org/channel/cactus?msg=H3KZMTkHwG8n2kWS2

@petermetz petermetz assigned petermetz and unassigned travis-payne Dec 3, 2021
petermetz added a commit to travis-payne/cactus that referenced this issue Dec 29, 2021
@petermetz
feat(quorum): private transaction support
70f6042 
fixes hyperledger-cacti#951

Signed-off-by: Travis Payne <[email protected]>
petermetz added a commit to travis-payne/cactus that referenced this issue Dec 29, 2021
@petermetz
feat(quorum): private transaction support
af28daa 
fixes hyperledger-cacti#951

Signed-off-by: Travis Payne <[email protected]>
Signed-off-by: Peter Somogyvari <[email protected]>
petermetz added a commit to travis-payne/cactus that referenced this issue Dec 29, 2021
@petermetz
feat(quorum): private transaction support
220c2c0 
fixes hyperledger-cacti#951

Signed-off-by: Travis Payne <[email protected]>
Signed-off-by: Peter Somogyvari <[email protected]>
petermetz added a commit to travis-payne/cactus that referenced this issue Jan 14, 2022
@petermetz
feat(quorum): private transaction support
d06e978 
fixes hyperledger-cacti#951

Signed-off-by: Travis Payne <[email protected]>
Signed-off-by: Peter Somogyvari <[email protected]>
RafaelAPB pushed a commit to RafaelAPB/blockchain-integration-framework that referenced this issue Mar 9, 2022
@RafaelAPB
test: adding quorum mp test ledger dockerfile
024de30 
Related to hyperledger-cacti#951

Signed-off-by: Travis Payne <[email protected]>
johnhomantaring pushed a commit to travis-payne/cactus that referenced this issue Apr 5, 2022
@petermetz @johnhomantaring
feat(quorum): private transaction support
3844682 
fixes hyperledger-cacti#951

Signed-off-by: johnhomantaring <[email protected]>
@petermetz petermetz removed their assignment Apr 8, 2022
johnhomantaring added a commit to travis-payne/cactus that referenced this issue May 30, 2022
@johnhomantaring
feat(quorum): private transaction support
00ea625 
fixes hyperledger-cacti#951

Signed-off-by: john.h.o.mantaring-at-475704139995 <[email protected]>
johnhomantaring added a commit to travis-payne/cactus that referenced this issue May 30, 2022
@johnhomantaring
feat(quorum): private transaction support
3f43cef 
fixes hyperledger-cacti#951

Signed-off-by: john.h.o.mantaring-at-475704139995 <[email protected]>
johnhomantaring added a commit to travis-payne/cactus that referenced this issue May 30, 2022
@johnhomantaring
feat(quorum): private transaction support
f8bef7a 
fixes hyperledger-cacti#951

Signed-off-by: john.h.o.mantaring-at-475704139995 <[email protected]>
aldousalvarez added a commit to aldousalvarez/cactus that referenced this issue Feb 16, 2023
@aldousalvarez @johnhomantaring @jagpreetsinghsasan
feat(quorum): private transaction support
eba671e 
Fixes hyperledger-cacti#951

Co-authored-by: Travis Payne <[email protected]>
Co-authored-by: johnhomantaring <[email protected]>
Co-authored-by: jagpreetsinghsasan <[email protected]>
Co-authored-by: aldousalvarez [email protected]
@aldousalvarez aldousalvarez mentioned this issue Feb 16, 2023
Merged
aldousalvarez added a commit to aldousalvarez/cactus that referenced this issue Feb 28, 2023
@aldousalvarez @johnhomantaring @jagpreetsinghsasan
feat(quorum): private transaction support
7fea3a0 
-----------------------------------------
	- Added v2.3.0-deploy-contract-from-json-private.test.ts that would support private
	transaction test for Quorum.
	- Added a QuorumPrivateTransactionConfig on openapi.json
	- Added Web3JsQuorum on plugin-ledger-connector-quorum and added a transact private
	method to be able to proceed with the private transaction.
	- Currently the privateUrl in the test is being truely optional
	and we need to address this in the future.
	- We are just passing privateUrl in all the instances even though
	we don't need to do private transactions everywhere.

Fixes hyperledger-cacti#951

Co-authored-by: Travis Payne <[email protected]>
Co-authored-by: johnhomantaring <[email protected]>
Co-authored-by: jagpreetsinghsasan <[email protected]>
Co-authored-by: aldousalvarez [email protected]
aldousalvarez added a commit to aldousalvarez/cactus that referenced this issue May 3, 2023
@aldousalvarez @johnhomantaring @jagpreetsinghsasan
feat(quorum): private transaction support
f6d9b86 
-----------------------------------------
	- Added v2.3.0-deploy-contract-from-json-private.test.ts that would support private
	transaction test for Quorum.
	- Added a QuorumPrivateTransactionConfig on openapi.json
	- Added Web3JsQuorum on plugin-ledger-connector-quorum and added a transact private
	method to be able to proceed with the private transaction.
	- Currently the privateUrl in the test is being truely optional
	and we need to address this in the future.
	- We are just passing privateUrl in all the instances even though
	we don't need to do private transactions everywhere.

Fixes hyperledger-cacti#951

Co-authored-by: Travis Payne <[email protected]>
Co-authored-by: johnhomantaring <[email protected]>
Co-authored-by: jagpreetsinghsasan <[email protected]>
Co-authored-by: aldousalvarez [email protected]
aldousalvarez added a commit to aldousalvarez/cactus that referenced this issue May 3, 2023
@aldousalvarez @johnhomantaring @jagpreetsinghsasan
feat(quorum): private transaction support
3ac6a46 
-----------------------------------------
	- Added v2.3.0-deploy-contract-from-json-private.test.ts that would support private
	transaction test for Quorum.
	- Added a QuorumPrivateTransactionConfig on openapi.json
	- Added Web3JsQuorum on plugin-ledger-connector-quorum and added a transact private
	method to be able to proceed with the private transaction.
	- Currently the privateUrl in the test is being truely optional
	and we need to address this in the future.
	- We are just passing privateUrl in all the instances even though
	we don't need to do private transactions everywhere.

Fixes hyperledger-cacti#951

Co-authored-by: Travis Payne <[email protected]>
Co-authored-by: johnhomantaring <[email protected]>
Co-authored-by: jagpreetsinghsasan <[email protected]>
Co-authored-by: aldousalvarez [email protected]
aldousalvarez added a commit to aldousalvarez/cactus that referenced this issue May 16, 2023
@aldousalvarez @johnhomantaring @jagpreetsinghsasan
feat(quorum): private transaction support
21bfd35 
-----------------------------------------
	- Added v2.3.0-deploy-contract-from-json-private.test.ts that would support private
	transaction test for Quorum.
	- Added a QuorumPrivateTransactionConfig on openapi.json
	- Added Web3JsQuorum on plugin-ledger-connector-quorum and added a transact private
	method to be able to proceed with the private transaction.
	- Currently the privateUrl in the test is being truely optional
	and we need to address this in the future.
	- We are just passing privateUrl in all the instances even though
	we don't need to do private transactions everywhere.

Fixes hyperledger-cacti#951

Co-authored-by: Travis Payne <[email protected]>
Co-authored-by: johnhomantaring <[email protected]>
Co-authored-by: jagpreetsinghsasan <[email protected]>
Co-authored-by: aldousalvarez [email protected]
petermetz added a commit to aldousalvarez/cactus that referenced this issue Jun 9, 2023
@aldousalvarez @johnhomantaring
@jagpreetsinghsasan @petermetz
feat(quorum): private transaction support
00bbaa4 
-----------------------------------------
	- Added v2.3.0-deploy-contract-from-json-private.test.ts that would support private
	transaction test for Quorum.
	- Added a QuorumPrivateTransactionConfig on openapi.json
	- Added Web3JsQuorum on plugin-ledger-connector-quorum and added a transact private
	method to be able to proceed with the private transaction.
	- Currently the privateUrl in the test is being truely optional
	and we need to address this in the future.
	- We are just passing privateUrl in all the instances even though
	we don't need to do private transactions everywhere.

Fixes hyperledger-cacti#951

Co-authored-by: Travis Payne <[email protected]>
Co-authored-by: johnhomantaring <[email protected]>
Co-authored-by: jagpreetsinghsasan <[email protected]>
Co-authored-by: aldousalvarez [email protected]
Co-authored-by: Peter Somogyvari <[email protected]>
Signed-off-by: Peter Somogyvari <[email protected]>
petermetz added a commit that referenced this issue Jun 12, 2023
@aldousalvarez @johnhomantaring
@jagpreetsinghsasan @petermetz
feat(quorum): private transaction support
3c944d6 
-----------------------------------------
	- Added v2.3.0-deploy-contract-from-json-private.test.ts that would support private
	transaction test for Quorum.
	- Added a QuorumPrivateTransactionConfig on openapi.json
	- Added Web3JsQuorum on plugin-ledger-connector-quorum and added a transact private
	method to be able to proceed with the private transaction.
	- Currently the privateUrl in the test is being truely optional
	and we need to address this in the future.
	- We are just passing privateUrl in all the instances even though
	we don't need to do private transactions everywhere.

Fixes #951

Co-authored-by: Travis Payne <[email protected]>
Co-authored-by: johnhomantaring <[email protected]>
Co-authored-by: jagpreetsinghsasan <[email protected]>
Co-authored-by: aldousalvarez [email protected]
Co-authored-by: Peter Somogyvari <[email protected]>
Signed-off-by: Peter Somogyvari <[email protected]>
barnapa pushed a commit to barnapa/cacti that referenced this issue Jun 15, 2023
@aldousalvarez @johnhomantaring
@jagpreetsinghsasan @petermetz @barnapa
feat(quorum): private transaction support
fe15a9e 
-----------------------------------------
	- Added v2.3.0-deploy-contract-from-json-private.test.ts that would support private
	transaction test for Quorum.
	- Added a QuorumPrivateTransactionConfig on openapi.json
	- Added Web3JsQuorum on plugin-ledger-connector-quorum and added a transact private
	method to be able to proceed with the private transaction.
	- Currently the privateUrl in the test is being truely optional
	and we need to address this in the future.
	- We are just passing privateUrl in all the instances even though
	we don't need to do private transactions everywhere.

Fixes hyperledger-cacti#951

Co-authored-by: Travis Payne <[email protected]>
Co-authored-by: johnhomantaring <[email protected]>
Co-authored-by: jagpreetsinghsasan <[email protected]>
Co-authored-by: aldousalvarez [email protected]
Co-authored-by: Peter Somogyvari <[email protected]>
Signed-off-by: Peter Somogyvari <[email protected]>
barnapa pushed a commit to barnapa/cacti that referenced this issue Jun 15, 2023
@aldousalvarez @johnhomantaring
@jagpreetsinghsasan @petermetz @barnapa
feat(quorum): private transaction support
5320880 
-----------------------------------------
	- Added v2.3.0-deploy-contract-from-json-private.test.ts that would support private
	transaction test for Quorum.
	- Added a QuorumPrivateTransactionConfig on openapi.json
	- Added Web3JsQuorum on plugin-ledger-connector-quorum and added a transact private
	method to be able to proceed with the private transaction.
	- Currently the privateUrl in the test is being truely optional
	and we need to address this in the future.
	- We are just passing privateUrl in all the instances even though
	we don't need to do private transactions everywhere.

Fixes hyperledger-cacti#951

Co-authored-by: Travis Payne <[email protected]>
Co-authored-by: johnhomantaring <[email protected]>
Co-authored-by: jagpreetsinghsasan <[email protected]>
Co-authored-by: aldousalvarez [email protected]
Co-authored-by: Peter Somogyvari <[email protected]>
Signed-off-by: Peter Somogyvari <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request Quorum
Projects
None yet
Milestone
v0.10.0
3 participants
@petermetz @travis-payne @TonyRowntree