Advertise proper exectution location

[jpogran]

Specify the workspace execution location so that VS Code prefers to install this extension in the remote host when using Remote Extensions like the Remote Container, SSH, or WSL extensions. VS Code will still install this extension locally when working on the local machine.

For more inforamtion see:

• https://code.visualstudio.com/api/advanced-topics/remote-extensions#incorrect-execution-location
• https://code.visualstudio.com/api/advanced-topics/extension-host#preferred-extension-location

Install to local:

Install to WSL:

[radeksimko]

https://code.visualstudio.com/api/advanced-topics/extension-host#preferred-extension-location

👍🏻 thank you for identifying the problem and for the fix

Do you reckon this would affect #768 in any way?

[jpogran]

Do you reckon this would affect #768 in any way?

In the short term, no. Longer term we have to modify the manifest and extension to support web browser only deployment, so this change doesn't prevent that.

The extensionKind setting determines where the extension is loaded. The workspace value indicates:

"extensionKind": ["workspace"] — Indicates the extension requires access to workspace contents and therefore needs to run where the workspace is located. That can be on the local machine or on the remote machine or Codespace. Most extensions fall into this category.

The extension relies on terraform-ls to provide most of the advanced language features and terraform-ls needs to run where the files are physically located to build a context for all features it provides. This means the extension needs to run where the workspace is located.

We could specify "extensionKind": ["workspace","ui"] so that the ui is a fallback, but I didn't test that combination. This might be a good idea to pursue before we merge this.

As for the web extension, in order for us to run there we have to either WASM the terraform-ls binary or modify the extension manifest to declare its a web extension, which will be pretty involved for us. I don't think that is a concern for us until we start to work on that.

[dbanck]

Nice catch!

[jpogran]

Updated the PR with ui and tested it out locally and in WSL. I don't have a SSH host up to check ATM and don't yet know how to test Codespaces.

[hashicorp-cla]

All committers have signed the CLA.

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.