Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Terraform extension available in "browser mode" #768

Closed
3 tasks done
radeksimko opened this issue Sep 14, 2021 · 8 comments
Closed
3 tasks done

Make Terraform extension available in "browser mode" #768

radeksimko opened this issue Sep 14, 2021 · 8 comments
Assignees
Labels

Comments

@radeksimko
Copy link
Member

radeksimko commented Sep 14, 2021

Problem Statement

GitHub employees and other users use VS Code in the browser for various reasons.
This extension currently isn't available for them.

Example https://github.dev/hashicorp/terraform-guides

Screenshot 2021-09-14 at 10 56 15

Expected User Experience

Extension is available to assist users in editing Terraform code in their browser, the same way as in desktop VS Code.

For example at https://vscode.dev/ or https://github.dev/

Proposal

https://code.visualstudio.com/docs/remote/codespaces#_why-is-an-extension-not-installable-in-the-browser

There is some documentation here: https://code.visualstudio.com/api/extension-guides/web-extensions

We could initially provide just a minimal extension for the web - e.g. with syntax highlighting only.

  • Investigate impact on telemetry logic
  • Investigate replacing of esbuild with webpack
  • Create browser entrypoint and link it from package.json per docs, e.g. "browser": "./dist/web/extension.js",

Longer-term we'd need to find out if there's any way or benefit from running LS in the browser - either via WASM or GopherJS.

@radeksimko radeksimko added enhancement New feature or request meta labels Sep 14, 2021
@andymac4182
Copy link

This would be awesome! I have been doing lots of PR reviews in the browser with github.dev

@Satak
Copy link

Satak commented Nov 19, 2021

Please make this available for github codespaces.

@jpogran
Copy link
Contributor

jpogran commented Mar 9, 2022

Hey @Satak, apologies for the delay in response. You should be able to use the extension in Codespaces:

image

Intellisense and other advanced language features work:

image

@Satak
Copy link

Satak commented Mar 10, 2022

@jpogran But it is not available for Codespaces in web browser:

image

@jpogran
Copy link
Contributor

jpogran commented Mar 10, 2022

Yep! I misunderstood what you were referring to because the two are called different things: https://docs.github.com/en/codespaces/the-githubdev-web-based-editor

We currently work in the full Codespaces environment. We don't yet work in the web-based editor.

@radeksimko radeksimko changed the title Make extension available in "browser mode" Make Terraform extension available in "browser mode" Jun 9, 2022
@jpogran
Copy link
Contributor

jpogran commented Nov 14, 2022

I am exceedingly happy to announce, that as of v2.25.0, we now work in github.dev and vscode.dev in the browser!

@radeksimko
Copy link
Member Author

As mentioned, we provide a basic web version of the extension from v2.25.0, therefore I am going to close this issue. I have however created a separate one in #1287 to track possible future enhancements in this area. Comments are welcomed there.

@github-actions
Copy link

github-actions bot commented Jan 2, 2023

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 2, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

4 participants