Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport of Guard against double marking in other locations in evaluate into v0.14 #27286

Merged
merged 1 commit into from
Dec 15, 2020

Conversation

teamterraform
Copy link
Contributor

Backport

This PR is auto-generated from #27281 to be assessed for backporting due to the inclusion of the label 0.14-backport.

The below text is copied from the body of the original PR.


Add checks for double marking elsewhere in the evaluate code -- this is tough to test for, so submitting this as a cautionary patch, carrying the fix for #27131 over to output values without waiting for a bug report of "how" this can happen.

@teamterraform teamterraform force-pushed the backport/pselle/double-mark/strangely-positive-ram branch from 1cf7caa to ade3789 Compare December 15, 2020 13:11
@teamterraform teamterraform requested a review from pselle December 15, 2020 13:11
@codecov
Copy link

codecov bot commented Dec 15, 2020

Codecov Report

Merging #27286 (ade3789) into v0.14 (c53371e) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted Files Coverage Δ
terraform/evaluate.go 53.30% <100.00%> (ø)
internal/providercache/dir.go 67.34% <0.00%> (-6.13%) ⬇️
terraform/node_resource_plan.go 95.32% <0.00%> (-1.87%) ⬇️
terraform/node_resource_apply_instance.go 75.79% <0.00%> (+0.79%) ⬆️
terraform/eval_diff.go 71.33% <0.00%> (+0.91%) ⬆️

@pselle pselle merged commit 51b3c98 into v0.14 Dec 15, 2020
@pselle pselle deleted the backport/pselle/double-mark/strangely-positive-ram branch December 15, 2020 16:46
@ghost
Copy link

ghost commented Jan 15, 2021

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@ghost ghost locked as resolved and limited conversation to collaborators Jan 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants