Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid double-marking variables #27131

Merged
merged 1 commit into from
Dec 4, 2020
Merged

Avoid double-marking variables #27131

merged 1 commit into from
Dec 4, 2020

Conversation

pselle
Copy link
Contributor

@pselle pselle commented Dec 3, 2020

It is possible, say with multiple layers of sensitive variables, to "double-mark" a variable. Add a check to ensure this does not happen.

Fixes #27095

@codecov
Copy link

codecov bot commented Dec 3, 2020

Codecov Report

Merging #27131 (cdbd68e) into master (6bacc7a) will increase coverage by 54.69%.
The diff coverage is 100.00%.

Impacted Files Coverage Δ
terraform/evaluate.go 52.89% <100.00%> (ø)
internal/getproviders/hash.go 42.05% <0.00%> (ø)
terraform/node_provider_abstract.go 66.66% <0.00%> (ø)
states/statemgr/helper.go 0.00% <0.00%> (ø)
terraform/node_resource_plan_destroy.go 80.00% <0.00%> (ø)
configs/resource.go 80.46% <0.00%> (ø)
command/013_config_upgrade.go 38.46% <0.00%> (ø)
lang/blocktoattr/fixup.go 74.57% <0.00%> (ø)
states/statemgr/statemgr_fake.go 54.54% <0.00%> (ø)
terraform/node_resource_abstract_instance.go 81.94% <0.00%> (ø)
... and 537 more

@pselle pselle force-pushed the pselle/double-marks branch from 4a07189 to cdbd68e Compare December 4, 2020 16:47
@pselle pselle requested a review from a team December 4, 2020 16:48
Copy link
Contributor

@alisdair alisdair left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! I appreciate the two different levels of test coverage added.

It is possible, say with multiple layers of
sensitive variables, to "double-mark" a variable.
Add a check to ensure this does not happen.
@pselle pselle force-pushed the pselle/double-marks branch from cdbd68e to 12b5d43 Compare December 4, 2020 18:10
@pselle pselle added the 0.14-backport If you add this label to a PR before merging, backport-assistant will open a new PR once merged label Dec 4, 2020
@pselle pselle merged commit ae02524 into master Dec 4, 2020
@pselle pselle deleted the pselle/double-marks branch December 4, 2020 18:21
@ghost
Copy link

ghost commented Jan 4, 2021

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@ghost ghost locked as resolved and limited conversation to collaborators Jan 4, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
0.14-backport If you add this label to a PR before merging, backport-assistant will open a new PR once merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sensitive errors if specified in multiple levels of variables
2 participants