Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

frontdoor: setting the read timeout to 5 minutes #7485

Merged
merged 4 commits into from
Jun 25, 2020

Conversation

tombuildsstuff
Copy link
Contributor

Taking a look through the frontdoor resource, it appears the timeouts were being called multiple times, meaning the timeout wouldn't fire correctly - this PR works through fixing those bugs - and also updates the read documentation

This also adds a warning if the read timeout is more than 5 minutes to indicate that there's a bug in the resource which needs fixing

cc @WodansSon for info

Fixes #7405

Copy link
Member

@jackofallops jackofallops left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@tombuildsstuff tombuildsstuff merged commit 9be058c into master Jun 25, 2020
@tombuildsstuff tombuildsstuff deleted the b/front-door-timeout branch June 25, 2020 15:58
@ghost
Copy link

ghost commented Jun 25, 2020

This has been released in version 2.16.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.16.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented Jul 26, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Jul 26, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Documentation for Front Door resource has wrong read timeout value
2 participants