Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation for Front Door resource has wrong read timeout value #7405

Closed
darrenk13 opened this issue Jun 19, 2020 · 3 comments · Fixed by #7408 or #7485
Closed

Documentation for Front Door resource has wrong read timeout value #7405

darrenk13 opened this issue Jun 19, 2020 · 3 comments · Fixed by #7408 or #7485
Assignees
Milestone

Comments

@darrenk13
Copy link

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Terraform (and AzureRM Provider) Version

Terraform v0.12.26
+ provider.azurerm v2.13.0

Affected Resource(s)

  • azurerm_frontdoor

Important Factoids

The documentation at https://www.terraform.io/docs/providers/azurerm/r/frontdoor.html#read indicates the read timeout is 6 hours. The source code at https://github.com/terraform-providers/terraform-provider-azurerm/blob/master/azurerm/internal/services/frontdoor/frontdoor_resource.go#L36 seems to indicate to me that the default for the read timeout is 5 minutes.

I ran into this as I was creating a front door and was getting the following error in way less than 6 hours:

Error: retrieving Front Door Frontend Endpoint "my-frontdoor-name" (Resource Group "my-resource-group"): frontdoor.FrontendEndpointsClient#Get: Failure sending request: StatusCode=0 -- Original Error: context deadline exceeded
@WodansSon WodansSon self-assigned this Jun 19, 2020
@WodansSon
Copy link
Collaborator

@darrenk13, good catch... thanks for opening this issue, and sorry about that... 🙂

@WodansSon WodansSon added this to the v2.16.0 milestone Jun 19, 2020
katbyte pushed a commit that referenced this issue Jun 23, 2020
…tation (#7408)

I have increased the timeout in the resource code from 5 minutes to 6 hours per the documentation. While this may seem excessive for a read, the time may be necessary for the frontdoor resource to complete successfully especially when custom domain SSL certs have been defined.

(fixes #7405)
@ghost
Copy link

ghost commented Jun 25, 2020

This has been released in version 2.16.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.16.0"
}
# ... other configuration ...

jrauschenbusch pushed a commit to jrauschenbusch/terraform-provider-azurerm that referenced this issue Jun 29, 2020
…tation (hashicorp#7408)

I have increased the timeout in the resource code from 5 minutes to 6 hours per the documentation. While this may seem excessive for a read, the time may be necessary for the frontdoor resource to complete successfully especially when custom domain SSL certs have been defined.

(fixes hashicorp#7405)
jrauschenbusch pushed a commit to jrauschenbusch/terraform-provider-azurerm that referenced this issue Jun 29, 2020
…tation (hashicorp#7408)

I have increased the timeout in the resource code from 5 minutes to 6 hours per the documentation. While this may seem excessive for a read, the time may be necessary for the frontdoor resource to complete successfully especially when custom domain SSL certs have been defined.

(fixes hashicorp#7405)
@ghost
Copy link

ghost commented Jul 24, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Jul 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.