Narrow @Beta annotations to the methods of Futures #3287
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Right now the @beta annotation on the class is easy to miss, especially since certain methods are also directly-annotated @beta. Remove the annotation from the class and apply it to each public member. In a follow-up PR I'd like to remove the @beta annotation from a few methods (transformAsync, catchingAsync, immediateFuture).
|
The change LGTM. As for the removals, I know @cpovirk had plans for addressing some of these, but I can't find the doc (if there was one) and he's currently out on leave. |
|
Hrm, those JDK 11 failures are bizarre. Maybe they're flaky? |
|
Ugh, actually I think the build is just failing on JDK 11 in general. I noticed that last week when I pushed the change adding JDK 11 to the travis build, but failed to do anything about it so far. |
|
Thanks. I've imported this into an internal CL I have going -- which will also remove a small number of |
Closed
ronshapiro
pushed a commit
that referenced
this pull request
Feb 14, 2019
collect - most Collectors (aside from BloomFilter and ImmutableRange*, as those whole classes are @beta (though I did remove the redundant @beta annotation from the Collector-returning methods for clarity)) - Maps: asConverter, immutableEnumMap - MultimapBuilder - Streams: stream(Iterable), concat io - ByteStreams: copy, toByteArray - CharStreams: copy, toString - Files: as(Char|Byte)(Source|Sink) util.concurrent - Futures: addCallback, getDone, getUnchecked, immediateCancelledFuture, immediateFailedFuture, immediateFuture - ListeningScheduledExecutorService - Uninterruptibles other - HtmlEscapers - Splitter.splitToList - Ticker Fixes #3287 Fixes #3251 (aside from ImmutableRange*, but those whole classes are @beta, anyway) Addresses the main concerns of #3285 but doesn't cover the broader request Fixes #3340 Partially addresses #3239 RELNOTES=Removed `@Beta` from a number of frequently used APIs. ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=232681253
Merged
ronshapiro
pushed a commit
that referenced
this pull request
Feb 26, 2019
collect - most Collectors (aside from BloomFilter and ImmutableRange*, as those whole classes are @beta (though I did remove the redundant @beta annotation from the Collector-returning methods for clarity)) - Maps: asConverter, immutableEnumMap - MultimapBuilder - Streams: stream(Iterable), concat io - ByteStreams: copy, toByteArray - CharStreams: copy, toString - Files: as(Char|Byte)(Source|Sink) util.concurrent - Futures: addCallback, getDone, getUnchecked, immediateCancelledFuture, immediateFailedFuture, immediateFuture - ListeningScheduledExecutorService - Uninterruptibles other - HtmlEscapers - Splitter.splitToList - Ticker Fixes #3287 Fixes #3251 (aside from ImmutableRange*, but those whole classes are @beta, anyway) Addresses the main concerns of #3285 but doesn't cover the broader request Fixes #3340 Partially addresses #3239 RELNOTES=Removed `@Beta` from a number of frequently used APIs. ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=232681253
ronshapiro
pushed a commit
that referenced
this pull request
Feb 26, 2019
collect - most Collectors (aside from BloomFilter and ImmutableRange*, as those whole classes are @beta (though I did remove the redundant @beta annotation from the Collector-returning methods for clarity)) - Maps: asConverter, immutableEnumMap - MultimapBuilder - Streams: stream(Iterable), concat io - ByteStreams: copy, toByteArray - CharStreams: copy, toString - Files: as(Char|Byte)(Source|Sink) util.concurrent - Futures: addCallback, getDone, getUnchecked, immediateCancelledFuture, immediateFailedFuture, immediateFuture - ListeningScheduledExecutorService - Uninterruptibles other - HtmlEscapers - Splitter.splitToList - Ticker Fixes #3287 Fixes #3251 (aside from ImmutableRange*, but those whole classes are @beta, anyway) Addresses the main concerns of #3285 but doesn't cover the broader request Fixes #3340 Partially addresses #3239 RELNOTES=Removed `@Beta` from a number of frequently used APIs. ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=232681253
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now the @beta annotation on the class is easy to miss, especially
since certain methods are also directly-annotated @beta.
Remove the annotation from the class and apply it to each public member.
In a follow-up PR I'd like to remove the @beta annotation from a few
methods (transformAsync, catchingAsync, immediateFuture).