Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

What's the status of ByteStreams API? #3239

Closed
pluttrell opened this issue Aug 15, 2018 · 2 comments
Closed

What's the status of ByteStreams API? #3239

pluttrell opened this issue Aug 15, 2018 · 2 comments
Assignees
@cgdecker
Labels
P3 no SLO package=io status=triaged type=debeta Request to remove something from @Beta

Comments

@pluttrell
Copy link

The com.google.common.io.ByteStreams class is marked with @Beta, which I understand to mean that it's public API might change and thus we're warned about using it with libraries (reference).

Is there an ETA when the API might be considered stable enough to remove @Beta?
@pluttrell pluttrell changed the title What's the API Status of com.google.common.io.ByteStreams? What's the status of ByteStreams API? Aug 15, 2018
@cgdecker cgdecker self-assigned this Aug 16, 2018
@cgdecker cgdecker added status=triaged type=other Miscellaneous activities not covered by other type= labels package=io labels Aug 16, 2018
@cgdecker
Copy link
Member

ByteStreams, and much of common.io, is definitely on the list of things we should be trying to get out of @Beta, we just haven't been good about prioritizing reviewing things for graduation from beta. Thanks for the reminder.

@cgdecker cgdecker added type=debeta Request to remove something from @Beta and removed type=other Miscellaneous activities not covered by other type= labels labels Oct 29, 2018
@ronshapiro ronshapiro mentioned this issue Feb 14, 2019
Closed
ronshapiro pushed a commit that referenced this issue Feb 14, 2019
@cpovirk @ronshapiro
Remove @beta from APIs:
91c249d 
collect
- most Collectors (aside from BloomFilter and ImmutableRange*, as those whole classes are @beta (though I did remove the redundant @beta annotation from the Collector-returning methods for clarity))
- Maps: asConverter, immutableEnumMap
- MultimapBuilder
- Streams: stream(Iterable), concat

io
- ByteStreams: copy, toByteArray
- CharStreams: copy, toString
- Files: as(Char|Byte)(Source|Sink)

util.concurrent
- Futures: addCallback, getDone, getUnchecked, immediateCancelledFuture, immediateFailedFuture, immediateFuture
- ListeningScheduledExecutorService
- Uninterruptibles

other
- HtmlEscapers
- Splitter.splitToList
- Ticker

Fixes #3287
Fixes #3251 (aside from ImmutableRange*, but those whole classes are @beta, anyway)
Addresses the main concerns of #3285 but doesn't cover the broader request
Fixes #3340
Partially addresses #3239

RELNOTES=Removed `@Beta` from a number of frequently used APIs.

-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=232681253
@ronshapiro ronshapiro mentioned this issue Feb 26, 2019
Merged
ronshapiro pushed a commit that referenced this issue Feb 26, 2019
@cpovirk @ronshapiro
Remove @beta from APIs:
068cb90 
collect
- most Collectors (aside from BloomFilter and ImmutableRange*, as those whole classes are @beta (though I did remove the redundant @beta annotation from the Collector-returning methods for clarity))
- Maps: asConverter, immutableEnumMap
- MultimapBuilder
- Streams: stream(Iterable), concat

io
- ByteStreams: copy, toByteArray
- CharStreams: copy, toString
- Files: as(Char|Byte)(Source|Sink)

util.concurrent
- Futures: addCallback, getDone, getUnchecked, immediateCancelledFuture, immediateFailedFuture, immediateFuture
- ListeningScheduledExecutorService
- Uninterruptibles

other
- HtmlEscapers
- Splitter.splitToList
- Ticker

Fixes #3287
Fixes #3251 (aside from ImmutableRange*, but those whole classes are @beta, anyway)
Addresses the main concerns of #3285 but doesn't cover the broader request
Fixes #3340
Partially addresses #3239

RELNOTES=Removed `@Beta` from a number of frequently used APIs.

-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=232681253
ronshapiro pushed a commit that referenced this issue Feb 26, 2019
@cpovirk @ronshapiro
Remove @beta from APIs:
6242bdd 
collect
- most Collectors (aside from BloomFilter and ImmutableRange*, as those whole classes are @beta (though I did remove the redundant @beta annotation from the Collector-returning methods for clarity))
- Maps: asConverter, immutableEnumMap
- MultimapBuilder
- Streams: stream(Iterable), concat

io
- ByteStreams: copy, toByteArray
- CharStreams: copy, toString
- Files: as(Char|Byte)(Source|Sink)

util.concurrent
- Futures: addCallback, getDone, getUnchecked, immediateCancelledFuture, immediateFailedFuture, immediateFuture
- ListeningScheduledExecutorService
- Uninterruptibles

other
- HtmlEscapers
- Splitter.splitToList
- Ticker

Fixes #3287
Fixes #3251 (aside from ImmutableRange*, but those whole classes are @beta, anyway)
Addresses the main concerns of #3285 but doesn't cover the broader request
Fixes #3340
Partially addresses #3239

RELNOTES=Removed `@Beta` from a number of frequently used APIs.

-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=232681253
@raghsriniv raghsriniv added the P3 no SLO label Jun 24, 2019
@kluever
Copy link
Member

kluever commented Oct 14, 2019

@elharo just requested (internally) a de-@beta'ing of ByteStreams.exhaust()

@copybara-service copybara-service bot mentioned this issue Apr 10, 2023
Closed
copybara-service bot pushed a commit that referenced this issue Apr 10, 2023
@kluever
Remove @Beta from ByteStreams.
4df1175 
Fixes #3239

RELNOTES=`io`: Remove `@Beta` from `ByteStreams`.
PiperOrigin-RevId: 523149778
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cgdecker cgdecker

Labels
P3 no SLO package=io status=triaged type=debeta Request to remove something from @Beta
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove @Beta from ByteStreams. google/guava
4 participants
@cgdecker @kluever @pluttrell @raghsriniv