fix: unique version per custom build #5896
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ldez
added
bug
ldez
force-pushed
the
fix/custom-randomize-version
branch
from
113b348 to
e748a4e
Compare
ldez
force-pushed
the
fix/custom-randomize-version
branch
from
e748a4e to
e0354ac
Compare
|
In fact, this is only a "problem" when the command is run with a local path because the But my modification based on time will always invalidate the cache when using CI, and this should not happen. So I need to change the approach. |
|
I found a solution by using the sumdb hash functions used by Go to compute the hash of local modules. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The version of the binary is used as a salt for the analysis cache.
This PR creates a unique version per custom build to invalidate the cache when modifying a custom linter without modifying the golangci-lint configuration.
The new version format is:
2.1.6-custom-gcl-yKhvEoEAOv2Z7u0U167sQAqiN0DW3mb0s5xCmd3Y.I think behind the AI slop PR #5894 there is a real issue.