feat: Clear analysis cache when running custom command #5894
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change ensures that the custom build of golangci-lint always starts with a clean cache by removing the cache directory before building. This prevents potential issues where stale cached analysis results might affect the custom build's behavior.
|
|
|
Hey, thank you for opening your first Pull Request ! |
|
The If you have a real problem, open an issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR adds automatic cache clearing when running the custom command to prevent outdated cache results from affecting the behavior.
Changes
Reason
When using the custom command, the linter itself is being modified with custom plugins or configurations. In this scenario, previously cached analysis results become invalid and can lead to incorrect linting results or unexpected behavior.
By ensuring a fresh start with a clean cache directory for each custom build, we guarantee that the analysis results accurately reflect the current state of the modified linter, providing more consistent and reliable results.