Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve flex list item padding #26779

Merged
merged 13 commits into from
Aug 29, 2023
Merged

Improve flex list item padding #26779

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
06ac7ae
fix
wxiaoguang Aug 28, 2023
816d518
Merge branch 'main' into fix-flex-list
GiteaBot Aug 29, 2023
4b10497
Merge branch 'main' into fix-flex-list
GiteaBot Aug 29, 2023
c9ebf23
Merge branch 'main' into fix-flex-list
GiteaBot Aug 29, 2023
02d0d0c
Merge branch 'main' into fix-flex-list
GiteaBot Aug 29, 2023
780d506
Merge branch 'main' into fix-flex-list
GiteaBot Aug 29, 2023
8efeebd
Merge branch 'main' into fix-flex-list
GiteaBot Aug 29, 2023
cb5f39d
Merge branch 'main' into fix-flex-list
GiteaBot Aug 29, 2023
64eede6
Merge branch 'main' into fix-flex-list
GiteaBot Aug 29, 2023
68e0b59
Merge branch 'main' into fix-flex-list
GiteaBot Aug 29, 2023
ca67ab1
Merge branch 'main' into fix-flex-list
GiteaBot Aug 29, 2023
a60b5f7
Merge branch 'main' into fix-flex-list
GiteaBot Aug 29, 2023
5ea44b0
Merge branch 'main' into fix-flex-list
GiteaBot Aug 29, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 20 additions & 3 deletions templates/devtest/flex-list.tmpl
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
{{template "base/head" .}}
<link rel="stylesheet" href="{{AssetUrlPrefix}}/css/devtest.css?v={{AssetVersion}}">
<div class="page-content devtest ui container">
<div>
<h1>Flex List</h1>
<div class="page-content devtest">
<div class="ui container">
<h1 class="gt-border-secondary-bottom">Flex List (standalone)</h1>
<div class="flex-list">
<div class="flex-item">
<div class="flex-item-leading">
Expand Down Expand Up @@ -84,6 +84,23 @@
</div>
</div>
</div>

<div class="divider gt-my-0"></div>

<h1>Flex List (with "ui segment")</h1>
<div class="ui attached segment">
<div class="flex-list">
<div class="flex-item">item 1</div>
<div class="flex-item">item 2</div>
</div>
</div>
<div class="ui attached segment">
<h1>Flex List (with "ui segment")</h1>
<div class="flex-list">
<div class="flex-item">item 1</div>
<div class="flex-item">item 2</div>
</div>
</div>
</div>
</div>
{{template "base/footer" .}}
15 changes: 10 additions & 5 deletions web_src/css/shared/flex-list.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,10 +6,7 @@
display: flex;
gap: 8px;
align-items: flex-start;
}

.flex-item:not(:last-child) {
padding-bottom: 8px;
padding: 1em 0;
}

.flex-item-baseline {
Expand Down Expand Up @@ -92,5 +89,13 @@

.flex-list > .flex-item + .flex-item {
border-top: 1px solid var(--color-secondary);
padding-top: 8px;
}

/* Fomantic UI segment has default "padding: 1em", so here it removes the padding-top and padding-bottom accordingly */
.ui.segment > .flex-list:first-child > .flex-item:first-child {
padding-top: 0;
}

.ui.segment > .flex-list:last-child > .flex-item:last-child {
padding-bottom: 0;
}