Improve flex list item padding #26779
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GiteaBot
added
the
lgtm/need 2
pull-request-size
bot
added
the
size/M
wxiaoguang
force-pushed
the
fix-flex-list
branch
from
2b49f7f to
06ac7ae
Compare
lunny
approved these changes
Aug 29, 2023
GiteaBot
added
lgtm/need 1
|
Of course you manage again to fix my code faster than I'm able to take a look at it 😆 I'm unsure if this change will affect some existing flex-list layouts, and I will only be able to take a look tomorrow unfortunately. |
delvh
approved these changes
Aug 29, 2023
GiteaBot
added
lgtm/done
appleboy
approved these changes
Aug 29, 2023
lunny
added
the
reviewed/wait-merge
GiteaBot
removed
the
reviewed/wait-merge
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
Aug 30, 2023
* giteaofficial/main:
Use `Set[Type]` instead of `map[Type]bool/struct{}`. (go-gitea#26804)
Fix verifyCommits error when push a new branch (go-gitea#26664)
Fix Uint8Array comparisons and update vitest (go-gitea#26805)
Add various missing files-changed dependencies (go-gitea#26799)
Improve flex list item padding (go-gitea#26779)
Include the GITHUB_TOKEN/GITEA_TOKEN secret for fork pull requests (go-gitea#26759)
feat(API): add route and implementation for creating/updating repository secret (go-gitea#26766)
Replace deprecated `elliptic.Marshal` (go-gitea#26800)
Updating the js libraries to latest version. (go-gitea#26795)
Fix some slice append usages (go-gitea#26778)
Use Go 1.21 for golangci-lint (go-gitea#26786)
Fix notification circle (border-radius) (go-gitea#26794)
Fix context filter has no effect in dashboard (go-gitea#26695)
Add default label in branch select list (go-gitea#26697)
Remove redundant nil check in `WalkGitLog` (go-gitea#26773)
Remove fomantic `item` module (go-gitea#26775)
Update info regarding internet connection for build (go-gitea#26776)
Fix being unable to use a repo that prohibits accepting PRs as a PR source. (go-gitea#26785)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace #26761
It's better to keep children elements simple, and let parent containers layout the necessary padding/margin.
The old
not(:last-child)and.flex-item + .flex-itemare not easy to maintain (for example, what if the developer would like to use a "tiny height" item?)The old approach also makes some UI look strange because the first item doesn't have proper padding-top.
In this PR, we just simply use
.flex-item { padding: ... }:ui segment) and without padding (div)And added more samples/examples.