Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix issue content history problems, improve UI #17404

Merged
merged 9 commits into from
Oct 23, 2021
Merged

Fix issue content history problems, improve UI #17404

merged 9 commits into from
Oct 23, 2021

Conversation

wxiaoguang
Copy link
Contributor

@wxiaoguang wxiaoguang commented Oct 22, 2021 •
edited
Loading

close #17393

  • Improve: make diff result better, make the HTML element fit the full height in the content history diff dialog
  • Bug fix: when edit the main issue, the poster is wrongly set to the issue poster

@wxiaoguang wxiaoguang added type/bug pr/wip This PR is not ready for review labels Oct 22, 2021
@wxiaoguang wxiaoguang added this to the 1.16.0 milestone Oct 22, 2021
@wxiaoguang wxiaoguang linked an issue Oct 22, 2021 that may be closed by this pull request
Issue comment edit-diff is wrong #17393
Closed
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Oct 22, 2021
@wxiaoguang wxiaoguang mentioned this pull request Oct 23, 2021
Closed
@wxiaoguang wxiaoguang mentioned this pull request Oct 23, 2021
Closed
@wxiaoguang wxiaoguang linked an issue Oct 23, 2021 that may be closed by this pull request
Issue comment URLs parsed / emitted incorrectly #17394
Closed
@wxiaoguang wxiaoguang changed the title WIP: Fix issue content history problems, improve UI WIP: Fix issue related bugs (markdown, content history, improve UI) Oct 23, 2021
@wxiaoguang wxiaoguang linked an issue Oct 23, 2021 that may be closed by this pull request
Markdown checkboxes rendered badly #17395
Closed
@wxiaoguang wxiaoguang removed the pr/wip This PR is not ready for review label Oct 23, 2021
@wxiaoguang wxiaoguang changed the title WIP: Fix issue related bugs (markdown, content history, improve UI) Fix issue related bugs (markdown, content history, improve UI) Oct 23, 2021
@wxiaoguang wxiaoguang force-pushed the issue-content-history-fix branch from 9cce822 to db52537 Compare October 23, 2021 12:07
@noerw
Copy link
Member

noerw commented Oct 23, 2021 •
edited
Loading

3. Bug fix: render Markdown http://AppURL/org/repo/issues/4?a=1&b=2#comment-123 test to HTML correctly,
4. Bug fix: fix the positions of checkboxes in rendered HTML, close Markdown checkboxes rendered badly #17395

@wxiaoguang these two affect 1.15, maybe put them in a separate PR for simpler backporting. 1/2 & 3/4 are not related anyway

This was unlinked from issues Oct 23, 2021
Issue comment URLs parsed / emitted incorrectly #17394
Closed
Markdown checkboxes rendered badly #17395
Closed
@wxiaoguang wxiaoguang changed the title Fix issue related bugs (markdown, content history, improve UI) Fix issue content history problems, improve UI Oct 23, 2021
@wxiaoguang
Copy link
Contributor Author

@noerw Done, split into 2 PRs.

@GiteaBot GiteaBot removed the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Oct 23, 2021
@GiteaBot GiteaBot added the lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. label Oct 23, 2021
@lunny lunny added the skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. label Oct 23, 2021
@wxiaoguang wxiaoguang merged commit ff96388 into go-gitea:main Oct 23, 2021
@wxiaoguang wxiaoguang deleted the issue-content-history-fix branch October 23, 2021 14:48
Chianina pushed a commit to Chianina/gitea that referenced this pull request Mar 28, 2022
@wxiaoguang
Fix issue content history problems, improve UI (go-gitea#17404)
1a951e8 
* Improve: make diff result better, make the HTML element fit the full height in the content history diff dialog
* Bug fix: when edit the main issue, the poster is wrongly set to the issue poster
Chianina pushed a commit to Chianina/gitea that referenced this pull request Mar 28, 2022
@wxiaoguang
Fix issue content history problems, improve UI (go-gitea#17404)
4539a2c 
* Improve: make diff result better, make the HTML element fit the full height in the content history diff dialog
* Bug fix: when edit the main issue, the poster is wrongly set to the issue poster
@go-gitea go-gitea locked and limited conversation to collaborators Apr 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lunny lunny lunny approved these changes

@noerw noerw noerw approved these changes

@delvh delvh delvh approved these changes

@silverwind silverwind Awaiting requested review from silverwind

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. type/bug
Projects
None yet
Milestone
1.16.0
Development

Successfully merging this pull request may close these issues.

Issue comment edit-diff is wrong
5 participants
@wxiaoguang @noerw @lunny @delvh @GiteaBot