Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue comment URLs parsed / emitted incorrectly #17394

Closed
noerw opened this issue Oct 21, 2021 · 5 comments · Fixed by #17411
Closed

Issue comment URLs parsed / emitted incorrectly #17394

noerw opened this issue Oct 21, 2021 · 5 comments · Fixed by #17411
Labels
outdated/theme/markdown type/bug
Milestone
1.15.6

Comments

@noerw
Copy link
Member

noerw commented Oct 21, 2021 •
edited
Loading

Gitea Version

a115309 (current 1.16), but I observed this since early in the 1.16 dev cycle

Git Version

No response

Operating System

No response

How are you running Gitea?

try.gitea.io

Database

No response

Can you reproduce the bug on the Gitea demo site?

Yes

Log Gist

https://try.gitea.io/noerw/hochwasser/issues/5

Description

Issue comment references don't get parsed correctly, when it isn't the last thing on the line.
Looks like the HTML emitted is wrong, the word following the link is missing. The href is empty.
See try.gitea.io link above.

Screenshots

No response
@noerw noerw added this to the 1.16.0 milestone Oct 21, 2021
@wxiaoguang
Copy link
Contributor

wxiaoguang commented Oct 22, 2021 •
edited
Loading

Somehow related to #17398 , maybe the code can be improved more.

It is a Markdown rendering problem.

@wxiaoguang
Copy link
Contributor

wxiaoguang commented Oct 23, 2021 •
edited
Loading

The problem is caused by the wrong HTML generated.

For example:

http://127.0.0.1:3000/root/test/issues/1#comment test

The genrated HTML is

<p><a href="http://127.0.0.1:3000/root/test/issues/1#comment test" class="ref-issue">#1</a></p>

Then SanitizeReader removes the invalid href.

@wxiaoguang
Copy link
Contributor

Fixed in #17404

@wxiaoguang wxiaoguang linked a pull request Oct 23, 2021 that will close this issue
Fix issue content history problems, improve UI #17404
Merged
@wxiaoguang wxiaoguang mentioned this issue Oct 23, 2021
Merged
@noerw noerw modified the milestones: 1.16.0, 1.15.6 Oct 23, 2021
@noerw
Copy link
Member Author

noerw commented Oct 23, 2021

just noted that 1.15.5 is affected too

@wxiaoguang
Copy link
Contributor

Yep, this is a very old bug, we can make a backport then

wxiaoguang added a commit to wxiaoguang/gitea that referenced this issue Oct 23, 2021
@wxiaoguang
Fix issue markdown bugs
1c4f239 
* Bug fix: render Markdown http://AppURL/org/repo/issues/4?a=1&b=2#comment-123 test to HTML correctly, close go-gitea#17394
* Bug fix: fix the positions of checkboxes in rendered HTML, close go-gitea#17395
@wxiaoguang wxiaoguang mentioned this issue Oct 23, 2021
Merged
@wxiaoguang wxiaoguang removed a link to a pull request Oct 23, 2021
Fix issue content history problems, improve UI #17404
Merged
wxiaoguang added a commit that referenced this issue Oct 23, 2021
@wxiaoguang
Fix issue markdown bugs (#17411)
6c49517 
* Bug fix: render Markdown http://AppURL/org/repo/issues/4?a=1&b=2#comment-123 test to HTML correctly, close #17394
* Bug fix: fix the positions of checkboxes in rendered HTML, close #17395
wxiaoguang added a commit to wxiaoguang/gitea that referenced this issue Oct 23, 2021
@wxiaoguang
Fix issue markdown bugs
00cf7e5 
* Bug fix: render Markdown `http://AppURL/org/repo/issues/4?a=1&b=2#comment-123 test` to HTML correctly, close go-gitea#17394
* Bug fix: fix the positions of checkboxes in rendered HTML, close go-gitea#17395

# Conflicts:
#	modules/markup/html.go
@wxiaoguang wxiaoguang mentioned this issue Oct 23, 2021
Merged
lunny pushed a commit that referenced this issue Oct 23, 2021
@wxiaoguang
Fix issue markdown bugs (#17413)
175ebc6 
* Bug fix: render Markdown `http://AppURL/org/repo/issues/4?a=1&b=2#comment-123 test` to HTML correctly, close #17394
* Bug fix: fix the positions of checkboxes in rendered HTML, close #17395

# Conflicts:
#	modules/markup/html.go
@fnetX fnetX mentioned this issue Nov 22, 2021
Closed
Chianina pushed a commit to Chianina/gitea that referenced this issue Mar 28, 2022
@wxiaoguang
Fix issue markdown bugs (go-gitea#17411)
7826f94 
* Bug fix: render Markdown http://AppURL/org/repo/issues/4?a=1&b=2#comment-123 test to HTML correctly, close go-gitea#17394
* Bug fix: fix the positions of checkboxes in rendered HTML, close go-gitea#17395
@go-gitea go-gitea locked and limited conversation to collaborators Apr 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
outdated/theme/markdown type/bug
Projects
None yet
Milestone
1.15.6
Development

Successfully merging a pull request may close this issue.

Fix issue markdown bugs wxiaoguang/gitea
2 participants
@wxiaoguang @noerw