Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rearrange the order of the merged by etc. in locale #13284

Merged

Conversation

zeripath
Copy link
Contributor

Fix #13260

Signed-off-by: Andrew Thornton [email protected]

@zeripath zeripath added the topic/ui Change the appearance of the Gitea UI label Oct 23, 2020
@zeripath zeripath added this to the 1.14.0 milestone Oct 23, 2020
@codecov-io
Copy link

codecov-io commented Oct 23, 2020

Codecov Report

Merging #13284 into master will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #13284      +/-   ##
==========================================
- Coverage   42.17%   42.15%   -0.02%     
==========================================
  Files         685      685              
  Lines       75571    75571              
==========================================
- Hits        31870    31860      -10     
- Misses      38477    38485       +8     
- Partials     5224     5226       +2     
Impacted Files Coverage Δ
modules/charset/charset.go 68.53% <0.00%> (-4.50%) ⬇️
services/pull/temp_repo.go 26.59% <0.00%> (-3.20%) ⬇️
services/pull/check.go 48.90% <0.00%> (-2.92%) ⬇️
services/pull/patch.go 53.97% <0.00%> (-1.71%) ⬇️
services/pull/pull.go 40.78% <0.00%> (ø)
modules/log/event.go 61.79% <0.00%> (+1.88%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f40a2a4...32a89f4. Read the comment docs.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Oct 23, 2020
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Oct 24, 2020
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Oct 24, 2020
@techknowlogick techknowlogick merged commit 0800c7e into go-gitea:master Oct 24, 2020
@zeripath zeripath deleted the fix-13260-improve-merged-by-locale branch October 24, 2020 04:33
@go-gitea go-gitea locked and limited conversation to collaborators Dec 14, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. topic/ui Change the appearance of the Gitea UI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorrect "merged by" value in pull requests list
6 participants