Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorrect "merged by" value in pull requests list #13260

Closed
1 of 6 tasks
lakostin opened this issue Oct 22, 2020 · 4 comments · Fixed by #13284
Closed
1 of 6 tasks

Incorrect "merged by" value in pull requests list #13260

lakostin opened this issue Oct 22, 2020 · 4 comments · Fixed by #13284
Labels
topic/ui Change the appearance of the Gitea UI

Comments

@lakostin
Copy link

  • Gitea version (or commit ref):
    1.14.0+dev-18-gd453533be
  • Git version:
    2.26.2
  • Operating system:
    docker Alpine Linux
  • Database (use [x]):
    • PostgreSQL
    • MySQL
    • MSSQL
    • SQLite
  • Can you reproduce the bug at https://try.gitea.io:
    • Yes (provide example URL)
    • No
  • Log gist:

Screenshots

Screenshot from 2020-10-21 18-17-42
Screenshot from 2020-10-21 18-17-55
@zeripath
Copy link
Contributor

One is likely to be the person who opened the PR and one is the person who merged the PR.

@lakostin
Copy link
Author

the problem is that it's written "merged by %person who opened pull request%"
but actually other person merged it

@zeripath
Copy link
Contributor

So it's not an incorrect value but rather that the label is unclear. The pulls list has to have the pr author on it - the person who merged it is irrelevant.

The string should be changed to be:

by andrei.kirin merged 11 minutes ago

@lunny lunny added the topic/ui Change the appearance of the Gitea UI label Oct 22, 2020
@lakostin
Copy link
Author

i would use this variant which is much more clear in my opinion:
opened by andrey.kirin; merged 11 minutes ago by anton.kostin

zeripath added a commit to zeripath/gitea that referenced this issue Oct 23, 2020
@zeripath
Rearrange the order of the merged by etc. in locale
1501a10 
Fix go-gitea#13260

Signed-off-by: Andrew Thornton <[email protected]>
@zeripath zeripath mentioned this issue Oct 23, 2020
Merged
techknowlogick pushed a commit that referenced this issue Oct 24, 2020
@zeripath
Rearrange the order of the merged by etc. in locale (#13284)
0800c7e 
Fix #13260

Signed-off-by: Andrew Thornton <[email protected]>
@go-gitea go-gitea locked and limited conversation to collaborators Dec 14, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
topic/ui Change the appearance of the Gitea UI
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Rearrange the order of the merged by etc. in locale zeripath/gitea
3 participants
@lunny @zeripath @lakostin