feat(txnames): Include transactions without source in clustering #51437
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Backend
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #51437 +/- ##
==========================================
- Coverage 81.24% 81.24% -0.01%
==========================================
Files 4896 4900 +4
Lines 205353 205432 +79
Branches 11101 11101
==========================================
+ Hits 166843 166905 +62
- Misses 38264 38281 +17
Partials 246 246
|
jjbayer
changed the title
jjbayer
changed the title
olksdr
approved these changes
Jun 22, 2023
Co-authored-by: Oleksandr <[email protected]>
jjbayer
added a commit
to getsentry/relay
that referenced
this pull request
Jun 27, 2023
getsentry/sentry#51437 expanded the scope of transaction name clustering to transactions from old SDKs that do not send a `source` annotation yet. This PR enables the application of rules to this type of transactions in Relay. Because there is a potential of triggering the cardinality limiter, I gated this new behavior with a feature flag. The condition for applying clusterer rules has now become more complicated, so I decided to remove / ignore the `scope` configuration flag entirely.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When an SDK does not provide a transaction source annotation, Relay does one of two things:
unknown.In the first case, we want to run the clusterer to detect high-cardinality patterns. We have to make the simplifying assumption that a transaction name containing
/is a URL.Note: This PR includes
source:nulltransactions in the clustering input. To also apply the discovered rules in Relay, we need another change in https://github.com/getsentry/relay/.ref: https://github.com/getsentry/team-ingest/issues/129