Skip to content

Commit 063c134

Browse files
authored
feat(txname): Apply transaction rules to legacy SDKs (#2250)
getsentry/sentry#51437 expanded the scope of transaction name clustering to transactions from old SDKs that do not send a `source` annotation yet. This PR enables the application of rules to this type of transactions in Relay. Because there is a potential of triggering the cardinality limiter, I gated this new behavior with a feature flag. The condition for applying clusterer rules has now become more complicated, so I decided to remove / ignore the `scope` configuration flag entirely.
1 parent f7e38b7 commit 063c134

File tree

5 files changed

+362
-97
lines changed

5 files changed

+362
-97
lines changed

CHANGELOG.md

+1
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,7 @@
99
- Add filter based on transaction names. ([#2118](https://github.com/getsentry/relay/pull/2118))
1010
- Drop profiles without a transaction in the same envelope. ([#2169](https://github.com/getsentry/relay/pull/2169))
1111
- Use GeoIP lookup also in non-processing Relays. Lookup from now on will be also run in light normalization. ([#2229](https://github.com/getsentry/relay/pull/2229))
12+
- Scrub identifiers from transactions for old SDKs. ([#2250](https://github.com/getsentry/relay/pull/2250))
1213

1314
## 23.6.1
1415

relay-dynamic-config/src/feature.rs

+5
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,8 @@ pub enum Feature {
1515
DeviceClassSynthesis,
1616
/// Enables metric extraction from spans.
1717
SpanMetricsExtraction,
18+
/// Apply transaction normalization rules to transactions from legacy SDKs.
19+
NormalizeLegacyTransactions,
1820
/// Forward compatibility.
1921
Unknown(String),
2022
}
@@ -49,6 +51,9 @@ impl Serialize for Feature {
4951
}
5052
Feature::DeviceClassSynthesis => "organizations:device-class-synthesis",
5153
Feature::SpanMetricsExtraction => "projects:span-metrics-extraction",
54+
Feature::NormalizeLegacyTransactions => {
55+
"organizations:transaction-name-normalize-legacy"
56+
}
5257
Feature::Unknown(s) => s,
5358
})
5459
}

0 commit comments

Comments
 (0)